Skip to content

Replace all uses of the internaltest package in sdk/metric #6536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrAlias opened this issue Mar 26, 2025 · 1 comment · Fixed by #6551
Closed

Replace all uses of the internaltest package in sdk/metric #6536

MrAlias opened this issue Mar 26, 2025 · 1 comment · Fixed by #6551
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:SDK Related to an SDK package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2025

store, err := ottest.SetEnvVariables(map[string]string{
envVarResourceAttributes: "key=value,rk5=7",
})
require.NoError(t, err)
defer func() { require.NoError(t, store.Restore()) }()

Replace with:

t.Setenv(envVarResourceAttributes, "key=value,rk5=7")
@MrAlias MrAlias added good first issue Good for newcomers pkg:SDK Related to an SDK package contribfest Issue good for KubeCon contribfest labels Mar 26, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 26, 2025
@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 27, 2025

Assigned to @zhengkezhou1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant