Skip to content

Remove the exporters/zipkin/internal package #6534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
MrAlias opened this issue Mar 26, 2025 · 1 comment · Fixed by #6566
Closed
3 tasks

Remove the exporters/zipkin/internal package #6534

MrAlias opened this issue Mar 26, 2025 · 1 comment · Fixed by #6566
Assignees
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:exporter:zipkin Related to the Zipkin exporter package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2025

The only use of the packages contained within the exporters/zipkin/internal package are:

  1. envStore, err := ottest.SetEnvVariables(map[string]string{
    envEndpoint: expectedEndpoint,
    })
    assert.NoError(t, err)
    defer func() {
    require.NoError(t, envStore.Restore())
    }()
  2. envStore := ottest.NewEnvStore()
    envStore.Record(envEndpoint)
    defer func() {
    require.NoError(t, envStore.Restore())
    }()
  • Replace the use in (1) with t.Setenv (e.g. t.Setenv(envEndpoint, expectedEndpoint))
  • Remove the reference in (2) (it has not been needed since Add support for go 1.23 #5720)
  • Remove the exporters/zipkin/internal package
@MrAlias MrAlias added contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:exporter:zipkin Related to the Zipkin exporter package labels Mar 26, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 26, 2025
@tongoss
Copy link
Contributor

tongoss commented Mar 27, 2025

@MrAlias , can I take this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:exporter:zipkin Related to the Zipkin exporter package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants