Skip to content

Remove errors.go from internal/internaltest #6521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MrAlias opened this issue Mar 26, 2025 · 1 comment · Fixed by #6559
Closed

Remove errors.go from internal/internaltest #6521

MrAlias opened this issue Mar 26, 2025 · 1 comment · Fixed by #6559
Assignees
@meyank-ssh
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers
Milestone
v1.36.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 26, 2025

This file contains unused types. It is not needed.

This is a generated file, so internal/gen.go will need to be updated.
@MrAlias MrAlias added contribfest Issue good for KubeCon contribfest good first issue Good for newcomers labels Mar 26, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 26, 2025
@meyank-ssh meyank-ssh mentioned this issue Mar 27, 2025
Merged
@meyank-ssh
Copy link
Contributor

Hey! I've opened a PR to address this issue: #6559
Let me know if any changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meyank-ssh meyank-ssh

Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers
Projects
None yet
Milestone
v1.36.0
Development

Successfully merging a pull request may close this issue.

internal/internaltest: Remove errors.go meyank-ssh/opentelemetry-go
2 participants
@MrAlias @meyank-ssh