Skip to content

Commit f9ba15f

Browse files
XSAMMrAlias
andauthored
Replace WithSyncer with WithBatcher in examples (#1044)
* Replace `WithSyncer` with `WithBatcher` in examples * update CHANGELOG Co-authored-by: Tyler Yahn <[email protected]>
1 parent 1dbc75b commit f9ba15f

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
1414
This removes the package dependencies of this bridge from the rest of the OpenTelemetry based project. (#1038)
1515
- Renamed `go.opentelemetry.io/otel/api/standard` package to `go.opentelemetry.io/otel/semconv` to avoid the ambiguous and generic name `standard` and better describe the package as containing OpenTelemetry semantic conventions. (#1016)
1616
- The environment variable used for resource detection has been changed from `OTEL_RESOURCE_LABELS` to `OTEL_RESOURCE_ATTRIBUTES` (#1042)
17+
- Replace `WithSyncer` with `WithBatcher` in examples. (#1044)
1718

1819
### Removed
1920

example/namedtracer/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ func initTracer() {
4444
log.Panicf("failed to initialize stdout exporter %v\n", err)
4545
return
4646
}
47-
tp, err = sdktrace.NewProvider(sdktrace.WithSyncer(exp),
47+
tp, err = sdktrace.NewProvider(sdktrace.WithBatcher(exp),
4848
sdktrace.WithConfig(sdktrace.Config{DefaultSampler: sdktrace.AlwaysSample()}))
4949
if err != nil {
5050
log.Panicf("failed to initialize trace provider %v\n", err)

example/otel-collector/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func initProvider() (*otlp.Exporter, *push.Controller) {
5959
// the service name used to display traces in backends
6060
kv.Key(semconv.ServiceNameKey).String("test-service"),
6161
)),
62-
sdktrace.WithSyncer(exp),
62+
sdktrace.WithBatcher(exp),
6363
)
6464
handleErr(err, "failed to create trace provider")
6565

exporters/otlp/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func main() {
4747
// sdktrace.WithMaxExportBatchSize(100),
4848
// ),
4949
// )
50-
traceProvider, err := sdktrace.NewProvider(sdktrace.WithSyncer(exporter))
50+
traceProvider, err := sdktrace.NewProvider(sdktrace.WithBatcher(exporter))
5151
if err != nil {
5252
log.Fatal("failed to create trace provider: %v", err)
5353
}

0 commit comments

Comments
 (0)