Skip to content

Add instrumentation for go-restful #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
MrAlias opened this issue Jun 18, 2020 · 3 comments · Fixed by #115 or #121
Closed
4 tasks done

Add instrumentation for go-restful #79

MrAlias opened this issue Jun 18, 2020 · 3 comments · Fixed by #115 or #121
Assignees
@evantorrie
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
untracked

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jun 18, 2020 •
edited by evantorrie
Loading

https://github.com/emicklei/go-restful

Tasks

  • code complete with tests passing
  • Dockerfile with example app showing instrumentation
  • documentation updated
  • instrumentation added to the opentelemetry registry

Prior Art
@MrAlias MrAlias added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed area: instrumentation Related to an instrumentation package labels Jun 18, 2020
@evantorrie evantorrie mentioned this issue Jun 30, 2020
Merged
@evantorrie evantorrie self-assigned this Jun 30, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 2, 2020

Closed in error, still need to complete the checklist.

@MrAlias MrAlias reopened this Jul 2, 2020
@evantorrie
Copy link
Contributor

Instrumentation registry added in PR open-telemetry/opentelemetry.io#213.

Note, I also added a couple of others that were missing in open-telemetry/opentelemetry.io#211

@evantorrie evantorrie mentioned this issue Jul 4, 2020
Merged
@evantorrie
Copy link
Contributor

Documentation is likely already sufficient, but gave a little more color in #121

@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evantorrie evantorrie

Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
untracked
3 participants
@pellared @MrAlias @evantorrie