Skip to content

Sync DynamoDB instrumentation attributes with Python instrumentation #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SenorMooMoo opened this issue Mar 2, 2023 · 3 comments
Closed

Comments

@SenorMooMoo
Copy link

The current instrumentation of DynamoDB does not set the same attributes:

  • Span name is different, does not include the operation like in Python (DynamoDB.GetItem vs DynamoDB)
  • rpc.method is set to aws.operation in Go
  • rpc.service is set to aws.service in Go
@dmathieu
Copy link
Member

dmathieu commented Mar 6, 2023

I haven't investigated this yet. But we should not "sync with python".
We should sync with the specification, if we don't yet: https://github.com/open-telemetry/opentelemetry-specification/blob/66f8c4c884d75ed3882af4f31ab036271bdd2a94/specification/trace/semantic_conventions/instrumentation/aws-sdk.md

@dmathieu
Copy link
Member

It appears the span name will be fixed with #3582.

@nemoshlag
Copy link
Member

Hi I think this issue can be closed as implemented

@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants