Skip to content

Update instrumentation readme to include links to instrumentation in external repos #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reggiemcdonald opened this issue Jun 30, 2020 · 2 comments · Fixed by #117
Closed
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@reggiemcdonald
Copy link
Contributor

As per discussion with @MrAlias, we agreed that the readme in the instrumentation directory should be updated to include links to integrations that are not in the opentelemetry-go-contrib repo.

@TigerHe7 and I found that go-redis/go already contains an integration for opentelemetry.

This issue is to update the readme with a table including a link to that repo.

@evantorrie
Copy link
Contributor

I checked https://opentelemetry.io/registry/ and the go-redis/go OTel integration does not appear there either. Should we take it upon ourselves to add this to the registry? Or expect the go-redis maintainers to do so?

@MrAlias
Copy link
Contributor

MrAlias commented Jul 1, 2020

I checked https://opentelemetry.io/registry/ and the go-redis/go OTel integration does not appear there either. Should we take it upon ourselves to add this to the registry? Or expect the go-redis maintainers to do so?

Probably worth doing ourselves given the newness of things. That said I know @vmihailenco has contributed to OTel already and might be interested in registering it.

@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants