Skip to content

Commit feff9c1

Browse files
authored
Merge branch 'master' into ci-badge
2 parents a904636 + cede46c commit feff9c1

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

.github/workflows/build_and_test.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ jobs:
3434
run: |
3535
make ci
3636
mkdir -p $TEST_RESULTS
37-
find . -name 'coverage.html' > "${TEST_RESULTS}/coverage.lst"
38-
tar -n -cf - -T "${TEST_RESULTS}/coverage.lst" | tar -C "${TEST_RESULTS}" -xvf -
37+
cp coverage.{txt,html} $TEST_RESULTS
3938
- uses: codecov/codecov-action@v1
4039
with:
4140
file: ./coverage.txt

Makefile

+11-7
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ endif
2323

2424
GOTEST_MIN = go test -v -timeout 30s
2525
GOTEST = $(GOTEST_MIN) -race
26-
GOTEST_WITH_COVERAGE = $(GOTEST) -coverprofile=coverage.txt -covermode=atomic
26+
GOTEST_WITH_COVERAGE = $(GOTEST) -coverprofile=coverage.out -covermode=atomic -coverpkg=./...
2727

2828
.DEFAULT_GOAL := precommit
2929

@@ -47,12 +47,16 @@ precommit: dependabot-check license-check generate build lint test
4747

4848
.PHONY: test-with-coverage
4949
test-with-coverage:
50-
set -e; for dir in $(ALL_COVERAGE_MOD_DIRS); do \
50+
set -e; \
51+
printf "" > coverage.txt; \
52+
for dir in $(ALL_COVERAGE_MOD_DIRS); do \
5153
echo "go test ./... + coverage in $${dir}"; \
5254
(cd "$${dir}" && \
5355
$(GOTEST_WITH_COVERAGE) ./... && \
54-
go tool cover -html=coverage.txt -o coverage.html); \
55-
done
56+
go tool cover -html=coverage.out -o coverage.html); \
57+
[ -f "$${dir}/coverage.out" ] && cat "$${dir}/coverage.out" >> coverage.txt; \
58+
done; \
59+
sed -i.bak -e '2,$$ { /^mode: /d; }' coverage.txt && rm coverage.txt.bak
5660

5761
.PHONY: ci
5862
ci: precommit check-clean-work-tree test-with-coverage test-386
@@ -65,7 +69,7 @@ test-gocql:
6569
CMD=cassandra IMG_NAME=cass-integ ./tools/wait.sh; \
6670
(cd instrumentation/github.com/gocql/gocql/otelgocql && \
6771
$(GOTEST_WITH_COVERAGE) . && \
68-
go tool cover -html=coverage.txt -o coverage.html); \
72+
go tool cover -html=coverage.out -o coverage.html); \
6973
docker stop cass-integ; \
7074
fi
7175

@@ -77,7 +81,7 @@ test-mongo-driver:
7781
CMD=mongo IMG_NAME=mongo-integ ./tools/wait.sh; \
7882
(cd instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo && \
7983
$(GOTEST_WITH_COVERAGE) . && \
80-
go tool cover -html=coverage.txt -o coverage.html); \
84+
go tool cover -html=coverage.out -o coverage.html); \
8185
docker stop mongo-integ; \
8286
fi
8387

@@ -89,7 +93,7 @@ test-gomemcache:
8993
CMD=gomemcache IMG_NAME=gomemcache-integ ./tools/wait.sh; \
9094
(cd instrumentation/github.com/bradfitz/gomemcache/memcache/otelmemcache && \
9195
$(GOTEST_WITH_COVERAGE) . && \
92-
go tool cover -html=coverage.txt -o coverage.html); \
96+
go tool cover -html=coverage.out -o coverage.html); \
9397
docker stop gomemcache-integ ; \
9498
fi
9599

0 commit comments

Comments
 (0)