Add registry link check target to Makefile (#446)

* Add registry link check target to Makefile

Signed-off-by: Matej Gera <[email protected]>

* Apply suggestions

- Do not exit, return warning only
- Put detectors in a separate type

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <[email protected]>

Author: matej-g

CHANGELOG.md

@@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+### Added
+
+- Add registry link check to `Makefile` and pre-release script. (#446)
+
 ## [0.15.0] - 2020-12-11
 
 ### Added

Makefile

@@ -6,6 +6,9 @@ ALL_DOCS := $(shell find . -name '*.md' -type f | sort)
 ALL_GO_MOD_DIRS := $(filter-out $(TOOLS_MOD_DIR), $(shell find . -type f -name 'go.mod' -exec dirname {} \; | sort))
 ALL_COVERAGE_MOD_DIRS := $(shell find . -type f -name 'go.mod' -exec dirname {} \; | egrep -v '^./example|^$(TOOLS_MOD_DIR)' | sort)
 
+# URLs to check if all contrib entries exist in the registry.
+REGISTRY_BASE_URL = https://raw.githubusercontent.com/open-telemetry/opentelemetry.io/master/content/en/registry
+CONTRIB_REPO_URL = https://github.com/open-telemetry/opentelemetry-go-contrib/tree/master
 
 # Mac OS Catalina 10.5.x doesn't support 386. Hence skip 386 test
 SKIP_386_TEST = false
@@ -159,6 +162,29 @@ license-check:
 	           exit 1; \
 	   fi
 
+.PHONY: registry-links-check
+registry-links-check:
+	@checkRes=$$( \
+		for f in $$( find ./instrumentation ./exporters ./detectors ! -path './instrumentation/net/*' -type f -name 'go.mod' -exec dirname {} \; | egrep -v '/example|/utils' | sort ) \
+			./instrumentation/net/http; do \
+			TYPE="instrumentation"; \
+			if $$(echo "$$f" | grep -q "exporters"); then \
+				TYPE="exporter"; \
+			fi; \
+			if $$(echo "$$f" | grep -q "detectors"); then \
+				TYPE="detector"; \
+			fi; \
+			NAME=$$(echo "$$f" | sed -e 's/.*\///' -e 's/.*otel//'); \
+			LINK=$(CONTRIB_REPO_URL)/$$(echo "$$f" | sed -e 's/..//' -e 's/\/otel.*$$//'); \
+			if ! $$(curl -s $(REGISTRY_BASE_URL)/$${TYPE}-go-$${NAME}.md | grep -q "$${LINK}"); then \
+				echo "$$f"; \
+			fi \
+		done; \
+	); \
+	if [ -n "$$checkRes" ]; then \
+		echo "WARNING: registry link check failed for the following packages:"; echo "$${checkRes}"; \
+	fi
+
 .PHONY: dependabot-check
 dependabot-check:
 	@result=$$( \

pre_release.sh

@@ -144,6 +144,9 @@ make lint
 # Add changes and commit.
 git add .
 make ci
+# Check whether registry links are up to date
+make registry-links-check
+
 declare COMMIT_MSG=""
 if [ -n "${OTEL_TAG}" ]; then
     COMMIT_MSG+="Bumping otel version to ${OTEL_TAG}"