Skip to content

Commit 90a1449

Browse files
MrAliaspellared
andauthored
Add @pyohannes as owner of EC2/ECS/EKS AWS detectors (#5656)
Closes #5542 Closes #5543 Closes #5544 @pyohannes please be sure to review our [CODEOWNER policy](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#code-owners). If you are okay with accepting the responsibilities, please approve this PR. --------- Co-authored-by: Robert Pająk <[email protected]>
1 parent 84cfe22 commit 90a1449

File tree

9 files changed

+5
-41
lines changed

9 files changed

+5
-41
lines changed

CHANGELOG.md

-9
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
2121

2222
- The `go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo` package is deprecated.
2323
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5551]. (#5598)
24-
- The `go.opentelemetry.io/contrib/detectors/aws/ec2` package is deprecated.
25-
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5542]. (#5636)
26-
- The `go.opentelemetry.io/contrib/detectors/aws/ecs` package is deprecated.
27-
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5543]. (#5637)
28-
- The `go.opentelemetry.io/contrib/detectors/aws/eks` package is deprecated.
29-
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5544]. (#5640)
3024
- The `go.opentelemetry.io/contrib/detectors/aws/lambda` package is deprecated.
3125
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5545]. (#5641)
3226
- The `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda` package is deprecated.
@@ -44,9 +38,6 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
4438
- The `go.opentelemetry.io/contrib/samplers/aws/xray` package is deprecated.
4539
If you would like to become a Code Owner of this module and prevent it from being removed, see [#5554]. (#5647)
4640

47-
[#5542]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542
48-
[#5543]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543
49-
[#5544]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5544
5041
[#5545]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5545
5142
[#5546]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5546
5243
[#5547]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5547

CODEOWNERS

+4-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ bridges/otelzap/ @open-te
3232

3333
config/ @open-telemetry/go-approvers @MadVikingGod @pellared @codeboten
3434

35-
detectors/aws/ @open-telemetry/go-approvers
35+
detectors/aws/ec2 @open-telemetry/go-approvers @pyohannes
36+
detectors/aws/ecs @open-telemetry/go-approvers @pyohannes
37+
detectors/aws/eks @open-telemetry/go-approvers @pyohannes
38+
detectors/aws/lambda @open-telemetry/go-approvers
3639
detectors/gcp/ @open-telemetry/go-approvers @dashpole
3740

3841
exporters/autoexport @open-telemetry/go-approvers @MikeGoldsmith @pellared

detectors/aws/ec2/ec2.go

-9
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
// Package ec2 provide an OpenTelemetry resource detector for AWS EC2
5-
// instances.
6-
//
7-
// Deprecated: ec2 has no Code Owner.
8-
// After August 21, 2024, it may no longer be supported and may stop
9-
// receiving new releases unless a new Code Owner is found. See
10-
// [this issue] if you would like to become the Code Owner of this module.
11-
//
12-
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5542
134
package ec2 // import "go.opentelemetry.io/contrib/detectors/aws/ec2"
145

156
import (

detectors/aws/ec2/go.mod

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Deprecated: ec2 has no Code Owner.
21
module go.opentelemetry.io/contrib/detectors/aws/ec2
32

43
go 1.21

detectors/aws/ecs/ecs.go

-9
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
// Package ecs provide an OpenTelemetry resource detector for AWS ECS
5-
// instances.
6-
//
7-
// Deprecated: ecs has no Code Owner.
8-
// After August 21, 2024, it may no longer be supported and may stop
9-
// receiving new releases unless a new Code Owner is found. See
10-
// [this issue] if you would like to become the Code Owner of this module.
11-
//
12-
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5543
134
package ecs // import "go.opentelemetry.io/contrib/detectors/aws/ecs"
145

156
import (

detectors/aws/ecs/go.mod

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Deprecated: ecs has no Code Owner.
21
module go.opentelemetry.io/contrib/detectors/aws/ecs
32

43
go 1.21

detectors/aws/ecs/test/ecs_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
"strings"
1212
"testing"
1313

14-
ecs "go.opentelemetry.io/contrib/detectors/aws/ecs" // nolint:staticcheck // deprecated.
14+
ecs "go.opentelemetry.io/contrib/detectors/aws/ecs"
1515
"go.opentelemetry.io/otel/attribute"
1616
"go.opentelemetry.io/otel/sdk/resource"
1717
semconv "go.opentelemetry.io/otel/semconv/v1.25.0"

detectors/aws/eks/detector.go

-9
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
// Package eks provide an OpenTelemetry resource detector for AWS EKS
5-
// instances.
6-
//
7-
// Deprecated: eks has no Code Owner.
8-
// After August 21, 2024, it may no longer be supported and may stop
9-
// receiving new releases unless a new Code Owner is found. See
10-
// [this issue] if you would like to become the Code Owner of this module.
11-
//
12-
// [this issue]: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/5544
134
package eks // import "go.opentelemetry.io/contrib/detectors/aws/eks"
145

156
import (

detectors/aws/eks/go.mod

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Deprecated: eks has no Code Owner.
21
module go.opentelemetry.io/contrib/detectors/aws/eks
32

43
go 1.21

0 commit comments

Comments
 (0)