[otelecho] Use SpanStatusFromHTTPStatusCodeAndSpanKind on the middleware (#1848)

* [otelecho] Use SpanStatusFromHTTPStatusCodeAndSpanKind on the middleware

* Add an entry to the changelog

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <[email protected]>

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -8,6 +8,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix the `echo` middleware by using `SpanKind.SERVER` when deciding the `SpanStatus`.
+  This makes `4xx` response codes to not be an error anymore. (#1848)
+
 ## [1.4.0/0.29.0] - 2022-02-14
 
 ### Added

instrumentation/github.com/labstack/echo/otelecho/echo.go

@@ -94,7 +94,7 @@ func Middleware(service string, opts ...Option) echo.MiddlewareFunc {
 			}
 
 			attrs := semconv.HTTPAttributesFromHTTPStatusCode(c.Response().Status)
-			spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCode(c.Response().Status)
+			spanStatus, spanMessage := semconv.SpanStatusFromHTTPStatusCodeAndSpanKind(c.Response().Status, oteltrace.SpanKindServer)
 			span.SetAttributes(attrs...)
 			span.SetStatus(spanStatus, spanMessage)