Skip to content

Commit 3803ef3

Browse files
authored
Merge branch 'main' into prometheus_bridge
2 parents 80ce130 + 84de4d2 commit 3803ef3

File tree

5 files changed

+7
-2
lines changed

5 files changed

+7
-2
lines changed

.github/ISSUE_TEMPLATE/bug_report_detector_gcp.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
2-
name: '[detector: aws:gcp] Bug report'
2+
name: '[detector: gcp] Bug report'
33
about: Create a report of invalid behavior about the gcp package to help us improve
44
title: ''
5-
labels: 'bug, area: detector, detector: aws:gcp'
5+
labels: 'bug, area: detector, detector: gcp'
66

77
---
88

detectors/gcp/cloud-function.go

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const (
2828
)
2929

3030
// NewCloudFunction will return a GCP Cloud Function resource detector.
31+
//
3132
// Deprecated: Use gcp.NewDetector() instead, which sets the same resource attributes.
3233
func NewCloudFunction() resource.Detector {
3334
return &cloudFunction{

detectors/gcp/cloud-run.go

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ type metadataClient interface {
3838
}
3939

4040
// CloudRun collects resource information of Cloud Run instance.
41+
//
4142
// Deprecated: Use gcp.NewDetector() instead. Note that it sets faas.* resource attributes instead of service.* attributes.
4243
type CloudRun struct {
4344
mc metadataClient
@@ -50,6 +51,7 @@ type CloudRun struct {
5051
var _ resource.Detector = (*CloudRun)(nil)
5152

5253
// NewCloudRun creates a CloudRun detector.
54+
//
5355
// Deprecated: Use gcp.NewDetector() instead. Note that it sets faas.* resource attributes instead of service.* attributes.
5456
func NewCloudRun() *CloudRun {
5557
return &CloudRun{

detectors/gcp/gce.go

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
)
2929

3030
// GCE collects resource information of GCE computing instances.
31+
//
3132
// Deprecated: Use gcp.NewDetector() instead, which sets the same resource attributes on GCE.
3233
type GCE struct{}
3334

detectors/gcp/gke.go

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
)
2828

2929
// GKE collects resource information of GKE computing instances.
30+
//
3031
// Deprecated: Use gcp.NewDetector() instead, which does NOT detect container, pod, and namespace attributes.
3132
// Set those using name using the OTEL_RESOURCE_ATTRIBUTES env var instead.
3233
type GKE struct{}

0 commit comments

Comments
 (0)