Skip to content

[feature request] ForceFlush checking succeeded status #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
erwinkramer opened this issue Apr 29, 2025 · 1 comment
Open

[feature request] ForceFlush checking succeeded status #2721

erwinkramer opened this issue Apr 29, 2025 · 1 comment
Labels
comp:extensions Things related to OpenTelemetry.Extensions enhancement New feature or request

Comments

@erwinkramer
Copy link

erwinkramer commented Apr 29, 2025 •
edited
Loading

Component

OpenTelemetry.Extensions

Is your feature request related to a problem?

There are some parts in the code that do ForceFlush: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/5aa6d86836bbc13659d61abcf3040a0811537f7e/src/OpenTelemetry.Extensions/Trace/AutoFlushActivityProcessor.cs#L79C18-L79C32

ForceFlush can return false, shouldn't that return value be checked? For example, if you implement AutoFlushActivityProcessor, it might make sense you want more reliability and thus want to check if everything is actually sent.
@erwinkramer erwinkramer added the enhancement New feature or request label Apr 29, 2025
@github-actions github-actions bot added the comp:extensions Things related to OpenTelemetry.Extensions label Apr 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Tagging component owner(s).

@MikeGoldsmith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:extensions Things related to OpenTelemetry.Extensions enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erwinkramer