Skip to content

Commit eae7b9c

Browse files
authored
[telemetry] Use Command/Version to populate service name/version attributes (#10645)
#### Link to tracking issue Fixes #10644 --------- Signed-off-by: Yuri Shkuro <[email protected]>
1 parent fbadc23 commit eae7b9c

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

.chloggen/telemetry-service-name.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: 'bug_fix'
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: 'service'
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Use Command/Version to populate service name/version attributes
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [10644]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: ['user']

service/telemetry/tracer.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ var (
2828
// New creates a new Telemetry from Config.
2929
func newTracerProvider(ctx context.Context, set Settings, cfg Config) (trace.TracerProvider, error) {
3030
attrs := map[string]interface{}{
31-
string(semconv.ServiceNameKey): set.BuildInfo.Version,
31+
string(semconv.ServiceNameKey): set.BuildInfo.Command,
32+
string(semconv.ServiceVersionKey): set.BuildInfo.Version,
3233
}
3334
for k, v := range cfg.Resource {
3435
if v != nil {

0 commit comments

Comments
 (0)