Skip to content

Commit c5d8528

Browse files
committed
Remove deprecated function IsValid from trace/span ID
Signed-off-by: Bogdan Drutu <[email protected]>
1 parent 347cfa9 commit c5d8528

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
## 🛑 Breaking changes 🛑
6+
7+
- Remove deprecated function `IsValid` from trace/span ID (#2522)
8+
59
## v0.20.0 Beta
610

711
## 🛑 Breaking changes 🛑

consumer/pdata/spanid.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,6 @@ func (t SpanID) HexString() string {
3939
return data.SpanID(t).HexString()
4040
}
4141

42-
// IsValid returns true if id contains at leas one non-zero byte.
43-
// Deprecated: use !IsEmpty() instead.
44-
func (t SpanID) IsValid() bool {
45-
return !data.SpanID(t).IsEmpty()
46-
}
47-
4842
// IsEmpty returns true if id doesn't contain at least one non-zero byte.
4943
func (t SpanID) IsEmpty() bool {
5044
return data.SpanID(t).IsEmpty()

consumer/pdata/traceid.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,6 @@ func (t TraceID) HexString() string {
3939
return data.TraceID(t).HexString()
4040
}
4141

42-
// IsValid returns true if id contains at leas one non-zero byte.
43-
// Deprecated: use !IsEmpty() instead.
44-
func (t TraceID) IsValid() bool {
45-
return !data.TraceID(t).IsEmpty()
46-
}
47-
4842
// IsEmpty returns true if id doesn't contain at least one non-zero byte.
4943
func (t TraceID) IsEmpty() bool {
5044
return data.TraceID(t).IsEmpty()

0 commit comments

Comments
 (0)