PR Feedback: add 1 test plus some comments

Author: Paulo Janotti

exporter/zipkinexporter/config.go

@@ -21,5 +21,8 @@ import (
 // Config defines configuration settings for the Zipkin exporter.
 type Config struct {
 	configmodels.ExporterSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct.
-	Endpoint                      string                   `mapstructure:"endpoint"`
+
+	// Endpoint is the URL to send the Zipkin trace data to (e.g.:
+	// http://some.url:9411/api/v2/spans).
+	Endpoint string `mapstructure:"endpoint"`
 }

exporter/zipkinexporter/config_test.go

@@ -20,6 +20,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"go.uber.org/zap"
 
 	"github.com/open-telemetry/opentelemetry-service/config"
 )
@@ -42,5 +43,11 @@ func TestLoadConfig(t *testing.T) {
 	// Endpoint doesn't have a default value so set it directly.
 	defaultCfg := factory.CreateDefaultConfig().(*Config)
 	defaultCfg.Endpoint = "http://some.location.org:9411/api/v2/spans"
-	assert.Equal(t, e0, defaultCfg)
+	assert.Equal(t, defaultCfg, e0)
+
+	e1 := cfg.Exporters["zipkin/2"]
+	assert.Equal(t, "zipkin/2", e1.(*Config).Name())
+	assert.Equal(t, "https://somedest:1234/api/v2/spans", e1.(*Config).Endpoint)
+	_, _, err = factory.CreateTraceExporter(zap.NewNop(), e1)
+	require.NoError(t, err)
 }

exporter/zipkinexporter/testdata/config.yaml

@@ -8,7 +8,7 @@ exporters:
   zipkin:
     endpoint: "http://some.location.org:9411/api/v2/spans"
   zipkin/2:
-    endpoint: "1.2.3.4:1234"
+    endpoint: "https://somedest:1234/api/v2/spans"
 
 pipelines:
   traces: