Skip to content

Commit 6315785

Browse files
authored
[scraperhelper] Update metric units (#10656)
#### Description `1` isn't an informative unit for metrics, this clarifies the unit. #### Link to tracking issue Fixes #10649
1 parent f085ac4 commit 6315785

File tree

4 files changed

+31
-6
lines changed

4 files changed

+31
-6
lines changed
+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: scraperhelper
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Update units for internal telemetry
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [10649]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

receiver/scraperhelper/documentation.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ Number of metric points that were unable to be scraped.
1212

1313
| Unit | Metric Type | Value Type | Monotonic |
1414
| ---- | ----------- | ---------- | --------- |
15-
| 1 | Sum | Int | true |
15+
| {datapoints} | Sum | Int | true |
1616

1717
### otelcol_scraper_scraped_metric_points
1818

1919
Number of metric points successfully scraped.
2020

2121
| Unit | Metric Type | Value Type | Monotonic |
2222
| ---- | ----------- | ---------- | --------- |
23-
| 1 | Sum | Int | true |
23+
| {datapoints} | Sum | Int | true |

receiver/scraperhelper/internal/metadata/generated_telemetry.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/scraperhelper/metadata.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ telemetry:
1212
scraper_scraped_metric_points:
1313
enabled: true
1414
description: Number of metric points successfully scraped.
15-
unit: "1"
15+
unit: "{datapoints}"
1616
sum:
1717
value_type: int
1818
monotonic: true
1919

2020
scraper_errored_metric_points:
2121
enabled: true
2222
description: Number of metric points that were unable to be scraped.
23-
unit: "1"
23+
unit: "{datapoints}"
2424
sum:
2525
value_type: int
2626
monotonic: true

0 commit comments

Comments
 (0)