Skip to content

Commit 5e910c6

Browse files
Remove unused Settings struct.
Fix Windows tests Signed-off-by: Patryk Matyjasek <[email protected]>
1 parent 13ca9f2 commit 5e910c6

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

component/component.go

-12
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ package component
1717
import (
1818
"context"
1919

20-
"go.uber.org/zap"
21-
2220
"go.opentelemetry.io/collector/config"
2321
)
2422

@@ -62,16 +60,6 @@ type Component interface {
6260
Shutdown(ctx context.Context) error
6361
}
6462

65-
// Settings is passed to ReceiverFactory.Create* functions.
66-
type Settings struct {
67-
// Logger that the factory can use during creation and can pass to the created
68-
// component to be used later as well.
69-
Logger *zap.Logger
70-
71-
// BuildInfo can be used by components for informational purposes
72-
BuildInfo BuildInfo
73-
}
74-
7563
// Kind represents component kinds.
7664
type Kind int
7765

service/application_windows_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func TestWindowsService_Execute(t *testing.T) {
3434
factories, err := defaultcomponents.Components()
3535
require.NoError(t, err)
3636

37-
s := NewWindowsService(svcSettings{BuildInfo: component.DefaultBuildInfo(), Factories: factories})
37+
s := NewWindowsService(AppSettings{BuildInfo: component.DefaultBuildInfo(), Factories: factories})
3838

3939
appDone := make(chan struct{})
4040
requests := make(chan svc.ChangeRequest)

0 commit comments

Comments
 (0)