[processor/logstransform]: Logstransform processor does not properly drain data

[BinaryFissionGames]

Component(s)

processor/logstransform

What happened?

Description

The logstransform processor does not drain log data that it has accepted in ConsumeLogs.
This means that when the collector is stopped, some log data may be lost.

I noticed this when I was writing a test to reproduce #31139 that I was getting 0 logs half the time, 500 logs the other half here:
975a39d#diff-2de55e867acbc6d11c6db4e7470806017e911f59d334e99352f19f7c18ed35b6R287

There are a couple of places where we bail out early when stopping, but I think it's preferable to keep going in these areas so we don't drop any logs on shutdown, e.g.:

opentelemetry-collector-contrib/pkg/stanza/adapter/frompdataconverter.go

Lines 108 to 124 in 8ccadc3

	for {
	select {
	case <-c.stopChan:
	return
	case workerItem, ok := <-c.workerChan:
	if !ok {
	return
	}
	select {
	case c.entriesChan <- convertFromLogs(workerItem):
	case <-c.stopChan:
	return
	}
	}
	}

Collector version

8ccadc3

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• processor/logstransform: @djaglowski @dehaansa

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[BinaryFissionGames]

This also seems related to #31074, since stanza adapter code is shared with this component.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/logstransform: @djaglowski @dehaansa

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/logstransform: @djaglowski @dehaansa

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/logstransform: @djaglowski @dehaansa

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.