exporter/signalfx: calculate extra network I/O metrics #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2553 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 429 429
Lines 21457 21457
=======================================
+ Hits 19593 19594 +1
+ Misses 1395 1394 -1
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Mar 4, 2021
jrcamp
reviewed
Mar 4, 2021
dmitryax
force-pushed
the
sfxexporter-network-disk-total
branch
from
308bdf5 to
0825231
Compare
asuresh4
approved these changes
Mar 4, 2021
bogdandrutu
approved these changes
Mar 4, 2021
dmitryax
force-pushed
the
sfxexporter-network-disk-total
branch
from
0825231 to
b7bb381
Compare
jrcamp
approved these changes
Mar 4, 2021
dmitryax
force-pushed
the
sfxexporter-network-disk-total
branch
from
b7bb381 to
80b7ab7
Compare
|
Please rebase |
Calculate extra metrics required on the backend: - system.network.io.total: total bytes I/O across all the network interfaces, keeping direction dimension - system.network.packets.total: total number of sent/received packets across all the network interfaces, keeping direction dimension
dmitryax
force-pushed
the
sfxexporter-network-disk-total
branch
from
80b7ab7 to
de9c2c1
Compare
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Calculate extra metrics required on the backend: - system.network.io.total: total bytes I/O across all the network interfaces, keeping direction dimension - system.network.packets.total: total number of sent/received packets across all the network interfaces, keeping direction dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate extra network I/O metrics required on the backend:
system.network.io.total: total bytes I/O across all the network interfaces, keeping thedirectiondimensionsystem.network.packets.total: total number of sent/received packets across all the network interfaces, keeping thedirectiondimension