remove escaping for mySQL

Author: justinianvoss22

internal/sqlquery/scraper.go

@@ -149,8 +149,12 @@ func buildPostgreSQLString(conn DataSourceConfig) (string, error) {
 func buildMySQLString(conn DataSourceConfig) (string, error) {
 	// MySQL connection string format: user:pass@tcp(host:port)/db?param1=value1&param2=value2
 	var auth string
+
+	// MySQL requires no escaping of username and password
 	if conn.Username != "" {
-		auth = fmt.Sprintf("%s:%s@", url.QueryEscape(conn.Username), url.QueryEscape(string(conn.Password)))
+		username := conn.Username
+		password := string(conn.Password)
+		auth = fmt.Sprintf("%s:%s@", username, password)
 	}
 
 	query := url.Values{}

internal/sqlquery/scraper_test.go

@@ -703,15 +703,15 @@ func TestBpConnectionStringBuilder(t *testing.T) {
 			expected:    "postgresql://user%40domain:pass%23word%40123@localhost:5432/mydb?app=my%23app&sslmode=disable",
 		},
 		{
-			name:        "mysql with invalid username and password",
+			name:        "mysql with invalid username and password, no escaping",
 			driver:      "mysql",
 			host:        "localhost",
 			port:        3306,
 			database:    "mydb",
 			username:    "user@domain+",
 			password:    "pass#word@123",
 			queryParams: map[string]any{"sslmode": "disable", "app": "my#app"},
-			expected:    "user%40domain%2B:pass%23word%40123@tcp(localhost:3306)/mydb?app=my%23app&sslmode=disable",
+			expected:    "user@domain+:pass#word@123@tcp(localhost:3306)/mydb?app=my%23app&sslmode=disable",
 		},
 		{
 			name:        "snowflake with invalid username and password",