Skip to content

Commit 344e4f2

Browse files
authored
[chore] [exporter/elasticsearch] remove defunct config (#33803)
**Description:** Remove exporter/elasticsearch config fields & mentions in the README. Nothing has ever used this config. They were added in #2324, but were not used. If one _were_ to add fields to all documents, then I think that should be done with a processor. **Link to tracking Issue:** N/A **Testing:** N/A **Documentation:** N/A
1 parent 0385b21 commit 344e4f2

File tree

3 files changed

+30
-8
lines changed

3 files changed

+30
-8
lines changed
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: elasticsearchexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Remove defunct "file" and "fields" configuration settings.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [33803]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
This is a breaking change only because removing the attributes would prevent
20+
collector startup if those attributes are specified, but otherwise there is
21+
no functional change. These configuration attributes have never done anything.
22+
23+
# If your change doesn't affect end users or the exported elements of any package,
24+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
25+
# Optional: The change log or logs in which this entry should be included.
26+
# e.g. '[user]' or '[user, api]'
27+
# Include 'user' if the change is relevant to end users.
28+
# Include 'api' if there is a change to a library API.
29+
# Default: '[user]'
30+
change_logs: [user]

exporter/elasticsearchexporter/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ behaviours, which may be configured through the following settings:
129129
- `raw`: Omit the `Attributes.` string prefixed to field names for log and
130130
span attributes as well as omit the `Events.` string prefixed to
131131
field names for span events.
132-
- `fields` (optional): Configure additional fields mappings.
133-
- `file` (optional): Read additional field mappings from the provided YAML file.
134132
- `dedup` (default=true; DEPRECATED, in future deduplication will always be enabled):
135133
Try to find and remove duplicate fields/attributes from events before publishing
136134
to Elasticsearch. Some structured logging libraries can produce duplicate fields

exporter/elasticsearchexporter/config.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,6 @@ type MappingsSettings struct {
160160
// Mode configures the field mappings.
161161
Mode string `mapstructure:"mode"`
162162

163-
// Additional field mappings.
164-
Fields map[string]string `mapstructure:"fields"`
165-
166-
// File to read additional fields mappings from.
167-
File string `mapstructure:"file"`
168-
169163
// Try to find and remove duplicate fields
170164
//
171165
// Deprecated: [v0.104.0] deduplication will always be applied in future,

0 commit comments

Comments
 (0)