Skip to content

Commit 088e40c

Browse files
authored
Revert "[exporter/prometheusremotewriteexporter]chore: log warning about remote_write_queue.num_consumers being a no-op" (#35845)
Reverts #34993
1 parent cd25e61 commit 088e40c

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

exporter/prometheusremotewriteexporter/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ The following settings can be optionally configured:
5454
- `remote_write_queue`: fine tuning for queueing and sending of the outgoing remote writes.
5555
- `enabled`: enable the sending queue (default: `true`)
5656
- `queue_size`: number of OTLP metrics that can be queued. Ignored if `enabled` is `false` (default: `10000`)
57-
- `num_consumers`: minimum number of workers to use to fan out the outgoing requests. (default: `5`) **WARNING:** Currently, num_consumers doesn't have any effect due to incompatibility with Prometheus remote write API. The value will be ignored. Please see https://github.com/open-telemetry/opentelemetry-collector/issues/2949 for more information.
57+
- `num_consumers`: minimum number of workers to use to fan out the outgoing requests. (default: `5`)
5858
- `resource_to_telemetry_conversion`
5959
- `enabled` (default = false): If `enabled` is `true`, all the resource attributes will be converted to metric labels by default.
6060
- `target_info`: customize `target_info` metric

exporter/prometheusremotewriteexporter/factory.go

-4
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,6 @@ func createMetricsExporter(ctx context.Context, set exporter.Settings,
4242
return nil, errors.New("invalid configuration")
4343
}
4444

45-
if prwCfg.RemoteWriteQueue.NumConsumers != 0 {
46-
set.Logger.Warn("Currently, remote_write_queue.num_consumers doesn't have any effect due to incompatibility with Prometheus remote write API. The value will be ignored. Please see https://github.com/open-telemetry/opentelemetry-collector/issues/2949 for more information.")
47-
}
48-
4945
prwe, err := newPRWExporter(prwCfg, set)
5046
if err != nil {
5147
return nil, err

0 commit comments

Comments
 (0)