Skip to content

Commit 056258e

Browse files
Cleanup makefile (#49)
- Removed unneeded very long default target, use "all" instead. - Also fixed "ci" target and actually used it in CirleCI build.
1 parent 01bc5ae commit 056258e

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ jobs:
1515
command: make install-tools
1616
- run:
1717
name: Verify
18-
command: make all
18+
command: make ci

Makefile

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,10 @@ all-pkgs:
3939
all-srcs:
4040
@echo $(ALL_SRC) | tr ' ' '\n' | sort
4141

42-
.DEFAULT_GOAL := addlicense-fmt-impi-vet-lint-goimports-misspell-staticcheck-test
42+
.DEFAULT_GOAL := all
4343

4444
.PHONY: all
45-
all: addlicense-fmt-impi-vet-lint-goimports-misspell-staticcheck-test otelcontribcol
46-
47-
.PHONY: addlicense-fmt-impi-vet-lint-goimports-misspell-staticcheck-test
48-
addlicense-fmt-impi-vet-lint-goimports-misspell-staticcheck-test: addlicense fmt impi vet lint goimports misspell staticcheck test
45+
all: addlicense fmt impi vet lint goimports misspell staticcheck test otelcontribcol
4946

5047
.PHONY: test
5148
test:
@@ -56,16 +53,14 @@ benchmark:
5653
$(GOTEST) -bench=. -run=notests $(ALL_PKGS)
5754

5855
.PHONY: ci
59-
ci: fmt vet lint goimports misspell staticcheck test-with-cover otelcontribcol
60-
$(MAKE) -C testbed install-tools
61-
$(MAKE) -C testbed runtests
56+
ci: all test-with-cover
6257

6358
.PHONY: test-with-cover
6459
test-with-cover:
6560
@echo Verifying that all packages have test files to count in coverage
6661
@scripts/check-test-files.sh $(subst github.com/open-telemetry/opentelemetry-collector-contrib/,./,$(ALL_PKGS))
6762
@echo pre-compiling tests
68-
@time go test -i $(ALL_PKGS)
63+
go test -i $(ALL_PKGS)
6964
$(GOTEST) $(GOTEST_OPT_WITH_COVERAGE) $(ALL_PKGS)
7065
go tool cover -html=coverage.txt -o coverage.html
7166

0 commit comments

Comments
 (0)