Destroys ContainerViews in client calls after using them for vcenterreceiver

Author: StefanKurek

.chloggen/vcenterreceiver_destroy_containerviews.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: 'bug_fix'
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: vcenterreceiver
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Adds destroys to the ContainerViews in the client.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [34254]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: This may not be necessary, but it should be better practice than not.
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

receiver/vcenterreceiver/client.go

@@ -91,6 +91,7 @@ func (vc *vcenterClient) Datacenters(ctx context.Context) ([]mo.Datacenter, erro
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve Datacenters: %w", err)
 	}
+	defer func() { _ = v.Destroy(ctx) }()
 
 	var datacenters []mo.Datacenter
 	err = v.Retrieve(ctx, []string{"Datacenter"}, []string{
@@ -109,6 +110,7 @@ func (vc *vcenterClient) Datastores(ctx context.Context, containerMoRef vt.Manag
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve Datastores: %w", err)
 	}
+	defer func() { _ = v.Destroy(ctx) }()
 
 	var datastores []mo.Datastore
 	err = v.Retrieve(ctx, []string{"Datastore"}, []string{
@@ -129,6 +131,7 @@ func (vc *vcenterClient) ComputeResources(ctx context.Context, containerMoRef vt
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve ComputeResources (& ClusterComputeResources): %w", err)
 	}
+	defer func() { _ = v.Destroy(ctx) }()
 
 	var computes []mo.ComputeResource
 	err = v.Retrieve(ctx, []string{"ComputeResource"}, []string{
@@ -150,6 +153,7 @@ func (vc *vcenterClient) HostSystems(ctx context.Context, containerMoRef vt.Mana
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve HostSystems: %w", err)
 	}
+	defer func() { _ = v.Destroy(ctx) }()
 
 	var hosts []mo.HostSystem
 	err = v.Retrieve(ctx, []string{"HostSystem"}, []string{
@@ -177,6 +181,7 @@ func (vc *vcenterClient) ResourcePools(ctx context.Context, containerMoRef vt.Ma
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve ResourcePools (&VirtualApps): %w", err)
 	}
+	defer func() { _ = v.Destroy(ctx) }()
 
 	var rps []mo.ResourcePool
 	err = v.Retrieve(ctx, []string{"ResourcePool"}, []string{
@@ -198,6 +203,7 @@ func (vc *vcenterClient) VMs(ctx context.Context, containerMoRef vt.ManagedObjec
 	if err != nil {
 		return nil, fmt.Errorf("unable to retrieve VMs: %w", err)
 	}
+	defer func() { _ = v.Destroy(ctx) }()
 
 	var vms []mo.VirtualMachine
 	err = v.Retrieve(ctx, []string{"VirtualMachine"}, []string{