Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose API for user provided SessionProvider #842

Open
cleverchuk opened this issue Feb 19, 2025 · 2 comments
Open

Expose API for user provided SessionProvider #842

cleverchuk opened this issue Feb 19, 2025 · 2 comments
Assignees

Comments

@cleverchuk
Copy link
Contributor

cleverchuk commented Feb 19, 2025

There isn't a public API for users to provide their own session manager or provider implementation. The existing API is package private. How about we expose an API for users to provide their own SessionProvider and SessionManager?

This would be useful for a use case where a user session represents a sequence of tasks that must be completed or canceled before the session can be closed or ended. The current implementation doesn't allow for that and uses arbitrary session identifier which may not represent how a user wants a session to be identified.

@bidetofevil bidetofevil self-assigned this Feb 25, 2025
@bidetofevil
Copy link
Contributor

Feels like this is something we should allow given the interface is public for a reason. I'll take a look

@breedx-splk
Copy link
Contributor

I still feel like we're being too generous with the session abstraction and should be more opinionated about it. We can/should expose the id generator for advanced users, but the behavior I think we should be better about managing. 🤷🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants