Skip to content

Disable old linuxfoundation CLA #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
29 tasks done
lizthegrey opened this issue Jun 9, 2020 · 25 comments · Fixed by #403
Closed
29 tasks done

Disable old linuxfoundation CLA #379

lizthegrey opened this issue Jun 9, 2020 · 25 comments · Fixed by #403

Comments

@flands
Copy link
Contributor

flands commented Jun 9, 2020

Can we please hold off on this for at least another week? At least Splunk and Grafana Labs are impacted by the new CLA and will require time to get it formally approved.

@lizthegrey
Copy link
Member Author

Can we please hold off on this for at least another week? At least Splunk and Grafana Labs are impacted by the new CLA and will require time to get it formally approved.

Yup, just a tracking issue, will wait another 1.5 weeks.

@lizthegrey
Copy link
Member Author

@flands would it help if instead of re-signing, I asked the Linux Foundation to migrate your existing CLA?

@ccaraman
Copy link
Contributor

ccaraman commented Jun 9, 2020

@open-telemetry/admins - We should undo the Community repository from enforcing the EasyCLA for now.

I think Community should be the last repository to enforce the new CLA as we have seen that there are large gaps in who got the communication around the new process. (#309)

@lizthegrey
Copy link
Member Author

@open-telemetry/admins - We should undo the Community repository from enforcing the EasyCLA for now.

I think Community should be the last repository to enforce the new CLA as we have seen that there are large gaps in who got the communication around the new process. (#309)

I'll revert!

@yurishkuro
Copy link
Member

At least Splunk and Grafana Labs are impacted by the new CLA and will require time to get it formally approved.

@flands it is my understanding that the CLA itself is unchanged, it's only the mechanism for checking it. When I did a test PR, all I had to do was to confirm that I still work at Uber, I was not required to re-sign the CLA. Are you seeing something different?

@lizthegrey
Copy link
Member Author

Filed https://jira.linuxfoundation.org/servicedesk/customer/portal/4/SUPPORT-1402 to ask the existing CLAs to be migrated to avoid the need to re-sign

@lizthegrey
Copy link
Member Author

Splunk - they signed a new CCLA and sent it to Chris Aniszczyk last night. I uploaded it into EasyCLA and cla manager Steve Flanders added an Approved list, so they should be good today.

Grafana - I'll transfer their document from v1 under CNCF-Grafana Labs. v1 also lists Anthony Woods as CLA Manager and grafana.com as the Allowed domain, so I'll transfer that info as well. 

@lizthegrey
Copy link
Member Author

Grafana's CLA has been migrated. I'm going to re-enable new CLA on community now.

@lizthegrey
Copy link
Member Author

@bogdandrutu how did discussion at maintainer meeting go? Do we need another week or am I good to swap the CLAs as of Friday?

@lizthegrey
Copy link
Member Author

It's now been 3 weeks, I'm going to go ahead and globally change, unless people object.

@lizthegrey
Copy link
Member Author

@open-telemetry/admins I've updated all but the ones for which I have no access as a GC member.

@yurishkuro
Copy link
Member

open-telemetry/opentelemetry-operator doesn't show EasyCLA as a check

@yurishkuro
Copy link
Member

same with open-telemetry/opentelemetry-python-contrib - no checks

open-telemetry/opentelemetry-auto-instr-ruby has no files

@lizthegrey
Copy link
Member Author

open-telemetry/opentelemetry-operator doesn't show EasyCLA as a check

A dummy PR needs to be opened to force EasyCLA checks to run then. I'll do that.

@lizthegrey
Copy link
Member Author

open-telemetry/opentelemetry-auto-instr-ruby has no files

@open-telemetry/ruby-maintainers do you need the auto-instr repo? or can we delete it until we need it? p.s. the name is out of spec with the naming of other language auto-instr where the language comes first.

@lizthegrey
Copy link
Member Author

open-telemetry/opentelemetry-operator doesn't show EasyCLA as a check

A dummy PR needs to be opened to force EasyCLA checks to run then. I'll do that.

@yurishkuro dummy PRs opened against otel-operator and otel-python-contrib, it should show now.

@yurishkuro
Copy link
Member

thanks, Liz, I enabled the checked in those two.

@lizthegrey
Copy link
Member Author

Great. I think we can declare this migration done. I've submitted a ticket to Linux Foundation support to ask them to disable the old CLA bot.

@yurishkuro
Copy link
Member

I deleted open-telemetry/opentelemetry-auto-instr-ruby. It was poorly set up anyway, without README or license.

@lizthegrey
Copy link
Member Author

one last item, @yurishkuro: Heather from CNCF/LF says we need to:

Hi Liz, i got clarification from the team and all that needs to be done here is for someone with rights on the org to remove the webhook.

It will look something like this:

Payload URL:
https://identity.linuxfoundation.org/lfcla/github/postreceive?ARG1=value&ARG2=value

Content type: application/json

Secret: the Github HMAC secret to enter here is a base64-encoded hash of an LF secret, concatenated with the group ID argument value (so that each project has their own secret).

@lizthegrey lizthegrey reopened this Jul 1, 2020
@yurishkuro
Copy link
Member

Just to confirm, we want to remove this webhook:

image

And I assume the EasyCLA will continue working because it's not integrated via webhook, but as a GitHub App:

image

@lizthegrey
Copy link
Member Author

that is correct, the github app is how we've integrated EasyCLA so the legacy webhook can be removed.

@yurishkuro
Copy link
Member

deleted webhook.

@lizthegrey
Copy link
Member Author

Opening a test PR to verify, but we can consider this closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants