Skip to content

Commit 8c95f84

Browse files
committed
Remove nodejs from reusable workflows
Signed-off-by: Samet Akcay <[email protected]>
1 parent 3a047cb commit 8c95f84

File tree

5 files changed

+2
-20
lines changed

5 files changed

+2
-20
lines changed

.github/actions/code-quality/pre-commit/action.yaml

+2-3
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,13 @@
2828
#
2929
# Required Inputs:
3030
# - python-version: Python version to use
31-
# - node-version: Node.js version to use
31+
# - node-version: Node.js version to use (defaults to "20")
3232
#
3333
# Example Usage:
3434
# steps:
3535
# - uses: ./.github/actions/code-quality/pre-commit
3636
# with:
3737
# python-version: "3.11"
38-
# node-version: "20.0.0"
3938
#
4039
# Note: Requires configured pre-commit hooks in repository
4140

@@ -50,7 +49,7 @@ inputs:
5049
node-version:
5150
description: "Node.js version to use"
5251
required: false
53-
default: "18.15.0"
52+
default: "20"
5453
skip:
5554
description: "Comma-separated list of hooks to skip"
5655
required: false

.github/workflows/_reusable-code-quality.yaml

-8
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
# Process Stages:
1414
# 1. Environment Preparation:
1515
# - Python setup
16-
# - Node.js setup
1716
# - Cache configuration
1817
#
1918
# 2. Quality Checks:
@@ -29,7 +28,6 @@
2928
#
3029
# Required Inputs:
3130
# - python-version: Python version for checks (default: "3.10")
32-
# - node-version: Node.js version for checks (default: "18.15.0")
3331
#
3432
# Example Usage:
3533
# 1. Default Configuration:
@@ -43,7 +41,6 @@
4341
# uses: ./.github/workflows/_reusable-code-quality.yaml
4442
# with:
4543
# python-version: "3.11"
46-
# node-version: "20.0.0"
4744
#
4845
# Note: Requires configured pre-commit hooks in repository
4946

@@ -56,10 +53,6 @@ on:
5653
description: "Python version for checks"
5754
type: string
5855
default: "3.10"
59-
node-version:
60-
description: "Node.js version for checks"
61-
type: string
62-
default: "18.15.0"
6356

6457
jobs:
6558
pre-commit:
@@ -72,4 +65,3 @@ jobs:
7265
- uses: ./.github/actions/code-quality/pre-commit
7366
with:
7467
python-version: ${{ inputs.python-version }}
75-
node-version: ${{ inputs.node-version }}

.github/workflows/_reusable-release-validation.yaml

-7
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
# Required Inputs:
4141
# - version: Version string to validate
4242
# - python-version: Python version for building
43-
# - node-version: Node.js version for tools
4443
# - verify-package: Whether to verify built package
4544
# - dry-run: Run without creating artifacts
4645
# - allow-prerelease: Allow RC versions
@@ -60,7 +59,6 @@
6059
# with:
6160
# version: "v1.2.3"
6261
# python-version: "3.10"
63-
# node-version: "18.15.0"
6462
# secrets:
6563
# codecov-token: ${{ secrets.CODECOV_TOKEN }}
6664
#
@@ -71,7 +69,6 @@
7169
# with:
7270
# version: "v1.2.3-rc1"
7371
# python-version: "3.10"
74-
# node-version: "18.15.0"
7572
# allow-prerelease: true
7673
# secrets:
7774
# codecov-token: ${{ secrets.CODECOV_TOKEN }}
@@ -90,9 +87,6 @@ on:
9087
python-version:
9188
required: true
9289
type: string
93-
node-version:
94-
required: true
95-
type: string
9690
verify-package:
9791
required: false
9892
type: boolean
@@ -141,7 +135,6 @@ jobs:
141135
uses: ./.github/workflows/_reusable-code-quality.yaml
142136
with:
143137
python-version: ${{ inputs.python-version }}
144-
node-version: ${{ inputs.node-version }}
145138

146139
tests:
147140
needs: [version-check]

.github/workflows/pr.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ jobs:
5252
uses: ./.github/workflows/_reusable-code-quality.yaml
5353
with:
5454
python-version: "3.10"
55-
node-version: "18.15.0"
5655

5756
# Test suite job using reusable workflow
5857
tests:

.github/workflows/release.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ jobs:
6868
with:
6969
version: ${{ github.event_name == 'push' && github.ref_name || inputs.version }}
7070
python-version: "3.10"
71-
node-version: "18.15.0"
7271
verify-package: true
7372
dry-run: ${{ github.event.inputs.dry_run || false }}
7473
allow-prerelease: true

0 commit comments

Comments
 (0)