Skip to content

Commit a1bc476

Browse files
committed
build: Unpin lxml.
libxmlsec and lxml need to be updated in lockstep and the version we had wouldn't work with Ubuntu 24.04 so unpinning lxml along with libxmlsec to see if that resolves the build and dependency issues.
1 parent 737b8e9 commit a1bc476

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

requirements/constraints.txt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,6 @@ event-tracking==3.0.0
105105
# https://github.com/openedx/edx-platform/issues/31616
106106
libsass==0.10.0
107107

108-
# Date: 2024-04-30
109-
# lxml>=5.0 introduced breaking changes related to system dependencies
110-
# lxml==5.2.1 introduced new extra so we'll nee to rename lxml --> lxml[html-clean]
111-
# This constraint can be removed once we upgrade to Python 3.11
112-
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35272
113-
lxml<5.0
114-
115108
# Date: 2018-12-14
116109
# markdown>=3.4.0 has failures due to internal refactorings which causes the tests to fail
117110
# pinning the version untill the issue gets resolved in the package itself

requirements/edx/kernel.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ importlib_metadata # Used to access entry_points in i18n_api pl
103103
jsonfield # Django model field for validated JSON; used in several apps
104104
laboratory # Library for testing that code refactors/infrastructure changes produce identical results
105105
importlib_metadata # Used to access entry_points in i18n_api plugin
106-
lxml # XML parser
106+
lxml[html_clean] # XML parser
107107
lti-consumer-xblock>=7.3.0
108108
mako # Primary template language used for server-side page rendering
109109
Markdown # Convert text markup to HTML; used in capa problems, forums, and course wikis

0 commit comments

Comments
 (0)