added: terminate extension hook on shutdown

Author: brendanfh

compiler/include/astnodes.h

@@ -2410,6 +2410,7 @@ void track_resolution_for_symbol_info(Context *context, AstNode *original, AstNo
 
 // Compiler Extensions
 TypeMatch compiler_extension_start(Context *context, const char *name, const char *containing_filename, Entity *ent, i32 *out_extension_id);
+void compiler_extension_terminate(Context *context, int extension_id);
 TypeMatch compiler_extension_expand_macro(
     Context *context,
     int extension_id,

compiler/src/extensions.c

@@ -57,11 +57,15 @@ static i32 extension_recv(CompilerExtension *ext, void *buf, i32 maxlen) {
     return bytes_read;
 }
 
+static void extension_wait(CompilerExtension *ext) {
+    int status;
+    waitpid(ext->pid, &status, 0);
+}
+
 static void extension_kill(CompilerExtension *ext) {
     ext->alive = 0;
     kill(ext->pid, SIGKILL);
-    int status;
-    waitpid(ext->pid, &status, 0);
+    extension_wait(ext);
 }
 
 static b32 extension_spawn(CompilerExtension *ext, const char *path) {
@@ -119,6 +123,9 @@ static b32 extension_poll_recv(CompilerExtension *ext) {
     return 0;
 }
 
+static void extension_wait(CompilerExtension *ext) {
+}
+
 static void extension_kill(CompilerExtension *ext) {
 }
 
@@ -262,13 +269,11 @@ b32 compiler_extension_negotiate_capabilities(Context *context, CompilerExtensio
         }
     }
 
-    {
-        compiler_event_log(
-            context,
-            "Extension '%s' spawned with protocol version %d.",
-            ext->name, extension_protocol_version
-        );
-    }
+    compiler_event_log(
+        context,
+        "Extension '%s' spawned with protocol version %d.",
+        ext->name, extension_protocol_version
+    );
 
     bh_arena_clear(&ext->arena);
     return 1;
@@ -493,3 +498,22 @@ TypeMatch compiler_extension_hook_stalled(Context *context, int extension_id) {
     }
 }
 
+void compiler_extension_terminate(Context *context, int extension_id) {
+    if (extension_id <= 0 || extension_id > bh_arr_length(context->extensions)) return;
+
+    CompilerExtension *ext = &context->extensions[extension_id - 1];
+
+    if (!ext->alive) return;
+    if (ext->state != COMP_EXT_STATE_READY) return;
+
+    extension_send_int(ext, MSG_HOST_TERMINATE);
+
+    compiler_event_log(
+        context,
+        "Waiting for extension '%s' to exit...",
+        ext->name
+    );
+
+    extension_wait(ext);
+}
+

compiler/src/library_main.c

@@ -170,6 +170,10 @@ void onyx_context_free(onyx_context_t *ctx) {
         shfree((*pscope)->symbols);
     }
 
+    bh_arr_each(CompilerExtension, ext, context->extensions) {
+        compiler_extension_terminate(context, ext->id);
+    }
+
     onyx_wasm_module_free(context->wasm_module);
     bh_arena_free(&context->ast_arena);
     bh_arr_free(context->loaded_files);