Skip to content

catalog path is not put into command state when merge operation is first #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balhoff opened this issue Mar 12, 2025 · 0 comments
Open
Labels

Comments

@balhoff
Copy link
Contributor

balhoff commented Mar 12, 2025

This took me a while to figure out. In a chain of commands like this:

robot --catalog catalog-v001.xml \
merge --collapse-import-closure false -i go-edit-filtered-xrefs.ofn -i imports/go_taxon_constraints.owl -i imports/reactome_xrefs_import.owl -i ../taxon_constraints/present_in_taxon.ofn -i imports/go-catalytic-activities-participants.owl \
remove --term 'IAO:0000116' --axioms annotation --signature true \
reason -r ELK -e asserted-only --exclude-duplicate-axioms true --exclude-tautologies structural \
relax \
reduce \
query --update ../sparql/insert-goterm-namespace.ru \
annotate -V http://purl.obolibrary.org/obo/go/releases/`date +%Y-%m-%d`/go.owl --annotation owl:versionInfo `date +%Y-%m-%d` -o output.owl

When the query command runs an update, it has to parse the resulting ontology again. It looks in the CommandState for a catalog that may have been used at the beginning, so that it can properly parse the ontology. However, merge does not put the catalog path into the state. Commands that expect a single ontology use updateInputOntology to get the current state and ontology; in this case if there is a catalog file the path is stored in the state.

But merge uses getInputOntologies, which returns a list of ontologies rather than an updated state.

I've been trying to decide on the best way to store the catalog path in this case, but wanted to go ahead and make the issue so it doesn't get lost. I'm only just now realizing that this command has been reloading imports off the web instead of locally partway through.

This problem may exist for other commands as well; I haven't checked.

@balhoff balhoff added the bug label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant