Merge pull request #948 from ontodev/logback

Replace slf4j-log4j12 with logback

Author: jamesaoverton

pom.xml

@@ -195,16 +195,33 @@
       <artifactId>junit</artifactId>
       <version>4.13.1</version>
     </dependency>
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-classic</artifactId>
+      <version>1.2.7</version>
+    </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
-      <artifactId>slf4j-log4j12</artifactId>
-      <version>1.7.30</version>
+      <artifactId>log4j-over-slf4j</artifactId>
+      <version>1.7.32</version>
     </dependency>
     <dependency>
       <groupId>org.semanticweb.elk</groupId>
       <artifactId>elk-owlapi</artifactId>
       <version>0.4.3</version>
       <exclusions>
+        <exclusion>
+          <groupId>org.slf4j</groupId>
+          <artifactId>slf4j-log4j12</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.slf4j</groupId>
+          <artifactId>slf4j-api</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.slf4j</groupId>
+          <artifactId>slf4j-simple</artifactId>
+        </exclusion>
         <exclusion>
           <groupId>net.sourceforge.owlapi</groupId>
           <artifactId>owlapi-apibinding</artifactId>

robot-command/src/main/java/org/obolibrary/robot/CommandLineHelper.java

@@ -1,5 +1,7 @@
 package org.obolibrary.robot;
 
+import ch.qos.logback.classic.Level;
+import ch.qos.logback.classic.Logger;
 import com.github.jsonldjava.core.Context;
 import java.io.*;
 import java.net.URI;
@@ -21,14 +23,13 @@
 import org.semanticweb.elk.owlapi.ElkReasonerFactory;
 import org.semanticweb.owlapi.model.*;
 import org.semanticweb.owlapi.reasoner.OWLReasonerFactory;
-import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import uk.ac.manchester.cs.jfact.JFactFactory;
 
 /** Convenience methods for working with command line options. */
 public class CommandLineHelper {
   /** Logger. */
-  private static final Logger logger = LoggerFactory.getLogger(CommandLineHelper.class);
+  private static final org.slf4j.Logger logger = LoggerFactory.getLogger(CommandLineHelper.class);
 
   /** Namespace for general input error messages. */
   private static final String NS = "errors#";
@@ -935,18 +936,18 @@ public static CommandLine maybeGetCommandLine(
     CommandLineParser parser = new DefaultParser();
     CommandLine line = parser.parse(options, args, stopAtNonOption);
 
-    String level;
+    Level level;
     if (line.hasOption("very-very-verbose")) {
-      level = "DEBUG";
+      level = Level.DEBUG;
     } else if (line.hasOption("very-verbose")) {
-      level = "INFO";
+      level = Level.INFO;
     } else if (line.hasOption("verbose")) {
-      level = "WARN";
+      level = Level.WARN;
     } else {
-      level = "ERROR";
+      level = Level.ERROR;
     }
-    org.apache.log4j.Logger root = org.apache.log4j.Logger.getRootLogger();
-    root.setLevel(org.apache.log4j.Level.toLevel(level));
+    Logger root = (Logger) LoggerFactory.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME);
+    root.setLevel(level);
 
     if (hasFlagOrCommand(line, "help")) {
       printHelp(usage, options);

robot-command/src/main/resources/log4j.properties

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+  <appender name="console" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder>
+      <pattern>%d %-5p %c - %m%n</pattern>
+    </encoder>
+  </appender>
+  <statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
+  <logger name="user" level="DEBUG"/>
+  <logger name="org.semanticweb.elk" level="off"/>
+  <logger name="org.obolibrary.obo2owl" level="off"/>
+  <root level="ERROR">
+    <appender-ref ref="console"/>
+  </root>
+</configuration>

robot-command/src/main/resources/logback.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+  <appender name="console" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder>
+      <pattern>%-5p %m%n</pattern>
+    </encoder>
+  </appender>
+  <statusListener class="ch.qos.logback.core.status.NopStatusListener"/>
+  <logger name="user" level="DEBUG"/>
+  <logger name="org.semanticweb.elk" level="off"/>
+  <logger name="org.obolibrary.obo2owl" level="off"/>
+  <root level="ERROR">
+    <appender-ref ref="console"/>
+  </root>
+</configuration>