Skip to content

Commit f95a047

Browse files
committed
Fixed several formatting issues
Signed-off-by: Paramvir Sran <[email protected]>
1 parent 68f25f2 commit f95a047

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

src/Compiler/CompilerUtils.cpp

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ using namespace mlir;
5454
using namespace onnx_mlir;
5555

5656
mlir::DefaultTimingManager timingManager;
57-
mlir::TimingScope rootScope;
58-
57+
mlir::TimingScope rootTimingScope;
5958
namespace onnx_mlir {
6059

6160
// Make a function that forces preserving all files using the runtime arguments
@@ -153,7 +152,8 @@ int Command::exec(std::string wdir) const {
153152
llvm::errs() << llvm::join(argsRef, " ") << "\n"
154153
<< "Error message: " << errMsg << "\n"
155154
<< "Program path: " << _path << "\n"
156-
<< "Command execution failed." << "\n";
155+
<< "Command execution failed."
156+
<< "\n";
157157
return rc;
158158
}
159159

@@ -333,7 +333,7 @@ std::string getTargetFilename(
333333
// Returns 0 on success, error code on failure.
334334
static int genLLVMBitcode(const mlir::OwningOpRef<ModuleOp> &module,
335335
std::string outputNameNoExt, std::string optimizedBitcodeNameWithExt) {
336-
auto llvmTiming = rootScope.nest(
336+
auto llvmTiming = rootTimingScope.nest(
337337
"[onnx-mlir] Compiling MLIR module to LLVM Optimized Bitcode");
338338
std::error_code error;
339339

@@ -406,7 +406,7 @@ static int genLLVMBitcode(const mlir::OwningOpRef<ModuleOp> &module,
406406
static int genModelObject(
407407
std::string bitcodeNameWithExt, std::string &modelObjNameWithExt) {
408408
auto objectTiming =
409-
rootScope.nest("[onnx-mlir] Compiling LLVM Bitcode to Object File");
409+
rootTimingScope.nest("[onnx-mlir] Compiling LLVM Bitcode to Object File");
410410
std::string llcPath = getToolPath("llc");
411411
Command llvmToObj(/*exePath=*/llcPath);
412412
setXllcOption({"--code-model", modelSizeStr[modelSize]});
@@ -427,7 +427,7 @@ static int genModelObject(
427427
// Return 0 on success, error code on failure.
428428
static int genJniObject(const mlir::OwningOpRef<ModuleOp> &module,
429429
std::string jniSharedLibPath, std::string jniObjPath) {
430-
auto jniTiming = rootScope.nest("[onnx-mlir] Compiling JNI Object File");
430+
auto jniTiming = rootTimingScope.nest("[onnx-mlir] Compiling JNI Object File");
431431
Command ar(/*exePath=*/getToolPath("ar", true));
432432
int rc = ar.appendStr("x")
433433
// old version of ar does not support --output so comment out
@@ -495,7 +495,7 @@ static int genSharedLib(std::string sharedLibNameWithExt,
495495
// Return 0 on success, error code on failure.
496496
static int genJniJar(const mlir::OwningOpRef<ModuleOp> &module,
497497
std::string modelSharedLibPath, std::string modelJniJarPath) {
498-
auto jniJarTiming = rootScope.nest("[onnx-mlir] Creating JNI Jar");
498+
auto jniJarTiming = rootTimingScope.nest("[onnx-mlir] Creating JNI Jar");
499499
llvm::SmallString<8> libraryPath(getLibraryPath());
500500
llvm::sys::path::append(libraryPath, "javaruntime.jar");
501501
std::string javaRuntimeJarPath = llvm::StringRef(libraryPath).str();
@@ -578,7 +578,8 @@ static int compileModuleToJniJar(
578578
#define NOEXECSTACK \
579579
{}
580580
#else
581-
#define NOEXECSTACK {"-z", "noexecstack"}
581+
#define NOEXECSTACK \
582+
{ "-z", "noexecstack" }
582583
#endif
583584
std::string modelSharedLibPath = getTargetFilename(jniLibBase, EmitLib);
584585
rc = genSharedLib(modelSharedLibPath, NOEXECSTACK,
@@ -889,7 +890,7 @@ int compileModule(mlir::OwningOpRef<ModuleOp> &module,
889890
mlir::MLIRContext &context, std::string outputNameNoExt,
890891
EmissionTargetType emissionTarget) {
891892
auto compileModuleTiming =
892-
rootScope.nest("[onnx-mlir] Compiling Module using MLIR");
893+
rootTimingScope.nest("[onnx-mlir] Compiling Module using MLIR");
893894

894895
int rc = setupModule(module, context, outputNameNoExt);
895896
if (rc != CompilerSuccess)

src/Compiler/CompilerUtils.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
#include <vector>
2828

2929
extern mlir::DefaultTimingManager timingManager;
30-
extern mlir::TimingScope rootScope;
30+
extern mlir::TimingScope rootTimingScope;
3131

3232
namespace onnx_mlir {
3333

src/Dialect/ONNX/ElementsAttr/ElementsAttrBuilder.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1073,8 +1073,8 @@ ElementsAttr ElementsAttrBuilder::nonZero(ElementsAttr elms) {
10731073
}
10741074

10751075
/*static*/
1076-
auto ElementsAttrBuilder::getElementsProperties(
1077-
ElementsAttr elements) -> ElementsProperties {
1076+
auto ElementsAttrBuilder::getElementsProperties(ElementsAttr elements)
1077+
-> ElementsProperties {
10781078
static Transformer nullTransformer = nullptr;
10791079
if (auto disposable = elements.dyn_cast<DisposableElementsAttr>()) {
10801080
ArrayRef<int64_t> strides = disposable.getStrides();

src/onnx-mlir.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ int main(int argc, char *argv[]) {
4646

4747
// Timing manager reporting enabled via "--enable-timing" compiler flag
4848
timingManager.setEnabled(enableTiming);
49-
rootScope = timingManager.getRootScope();
50-
auto setupTiming = rootScope.nest("[onnx-mlir] Loading Dialects");
49+
rootTimingScope = timingManager.getRootScope();
50+
auto setupTiming = rootTimingScope.nest("[onnx-mlir] Loading Dialects");
5151

5252
// Special handling of outputBaseName to derive output filename.
5353
// outputBaseName must specify a file, so ignore invalid values
@@ -75,7 +75,7 @@ int main(int argc, char *argv[]) {
7575
loadDialects(context);
7676
setupTiming.stop();
7777
auto inputFileTiming =
78-
rootScope.nest("[onnx-mlir] Importing Input Model to MLIR");
78+
rootTimingScope.nest("[onnx-mlir] Importing Input Model to MLIR");
7979
mlir::OwningOpRef<mlir::ModuleOp> module;
8080
std::string errorMessage;
8181
int rc = processInputFile(inputFilename, context, module, &errorMessage);

0 commit comments

Comments
 (0)