response to comments

Signed-off-by: Alexandre Eichenberger <[email protected]>

Author: AlexandreEichenberger

src/Accelerators/NNPA/Conversion/ONNXToZHigh/RewriteONNXForZHigh.cpp

@@ -671,15 +671,13 @@ void getRewriteONNXForZHighDynamicallyLegal(
         return isSuitableForZDNN<ONNXConvOp>(op) ||
                !canInferencePadsForNNPAConv(op);
       });
-#if 1
   addDynamicallyLegalOpFor<ONNXReshapeOp>(target, dimAnalysis,
       [](ONNXReshapeOp op, const DimAnalysis *dimAnalysis) {
         // Get rid of identity reshape here, as it impacts stick/unstick.
         // So all reshape are legal, unless it is an identity reshape, in which
         // case there is a rule here to remove it.
         return !isIdentityReshape(op, dimAnalysis);
       });
-#endif
 }
 
 struct RewriteONNXForZHighPass

src/Accelerators/NNPA/Transform/ZLow/ZLowStickExpansion.cpp

@@ -51,7 +51,8 @@ namespace zlow {
 using MDBuilder = MultiDialectBuilder<IndexExprBuilderForKrnl, KrnlBuilder,
     MathBuilder, MemRefBuilder, VectorBuilder, AffineBuilder, SCFBuilder>;
 
-/// Remove unstick if there is no use of its second operand except itself.
+/// Expand unstick operation to compiler generated code for suitable patterns,
+/// aka all but the 1D and 2DS data layouts at this time.
 class UnstickExpansionPattern : public OpRewritePattern<ZLowUnstickOp> {
 public:
   UnstickExpansionPattern(MLIRContext *context, bool enableParallelism = false)
@@ -287,7 +288,8 @@ class UnstickExpansionPattern : public OpRewritePattern<ZLowUnstickOp> {
   }
 };
 
-/// Remove stick if there is no use of its second operand except itself.
+/// Expand stick operation to compiler generated code for suitable patterns, aka
+/// all but the 1D and 2DS data layouts at this time.
 class StickExpansionPattern : public OpRewritePattern<ZLowStickOp> {
 public:
   StickExpansionPattern(MLIRContext *context, bool enableParallelism = false)