Skip to content

Commit 648d689

Browse files
alafanecherejatinyadav-cc
authored andcommitted
✨ source-amplitude: migrate to poetry (airbytehq#35162)
1 parent 8170876 commit 648d689

File tree

6 files changed

+1163
-123
lines changed

6 files changed

+1163
-123
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,86 +1,55 @@
1-
# Amplitude Source
1+
# Amplitude source connector
22

3-
This is the repository for the Amplitude configuration based source connector.
3+
4+
This is the repository for the Amplitude source connector, written in Python.
45
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.com/integrations/sources/amplitude).
56

67
## Local development
78

8-
#### Create credentials
9-
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/amplitude)
10-
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_amplitude/spec.yaml` file.
11-
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
12-
See `integration_tests/sample_config.json` for a sample config file.
13-
14-
**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source amplitude test creds`
15-
and place them into `secrets/config.json`.
16-
17-
### Locally running the connector docker image
18-
19-
9+
### Prerequisites
10+
* Python (~=3.9)
11+
* Poetry (~=1.7) - installation instructions [here](https://python-poetry.org/docs/#installation)
2012

21-
#### Use `airbyte-ci` to build your connector
22-
The Airbyte way of building this connector is to use our `airbyte-ci` tool.
23-
You can follow install instructions [here](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md#L1).
24-
Then running the following command will build your connector:
2513

14+
### Installing the connector
15+
From this connector directory, run:
2616
```bash
27-
airbyte-ci connectors --name=source-amplitude build
17+
poetry install --with dev
2818
```
29-
Once the command is done, you will find your connector image in your local docker registry: `airbyte/source-amplitude:dev`.
30-
31-
##### Customizing our build process
32-
When contributing on our connector you might need to customize the build process to add a system dependency or set an env var.
33-
You can customize our build process by adding a `build_customization.py` module to your connector.
34-
This module should contain a `pre_connector_install` and `post_connector_install` async function that will mutate the base image and the connector container respectively.
35-
It will be imported at runtime by our build process and the functions will be called if they exist.
36-
37-
Here is an example of a `build_customization.py` module:
38-
```python
39-
from __future__ import annotations
40-
41-
from typing import TYPE_CHECKING
4219

43-
if TYPE_CHECKING:
44-
# Feel free to check the dagger documentation for more information on the Container object and its methods.
45-
# https://dagger-io.readthedocs.io/en/sdk-python-v0.6.4/
46-
from dagger import Container
4720

21+
### Create credentials
22+
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/amplitude)
23+
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_amplitude/spec.yaml` file.
24+
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
25+
See `sample_files/sample_config.json` for a sample config file.
4826

49-
async def pre_connector_install(base_image_container: Container) -> Container:
50-
return await base_image_container.with_env_variable("MY_PRE_BUILD_ENV_VAR", "my_pre_build_env_var_value")
5127

52-
async def post_connector_install(connector_container: Container) -> Container:
53-
return await connector_container.with_env_variable("MY_POST_BUILD_ENV_VAR", "my_post_build_env_var_value")
28+
### Locally running the connector
29+
```
30+
poetry run source-amplitude spec
31+
poetry run source-amplitude check --config secrets/config.json
32+
poetry run source-amplitude discover --config secrets/config.json
33+
poetry run source-amplitude read --config secrets/config.json --catalog sample_files/configured_catalog.json
5434
```
5535

56-
#### Build your own connector image
57-
This connector is built using our dynamic built process in `airbyte-ci`.
58-
The base image used to build it is defined within the metadata.yaml file under the `connectorBuildOptions`.
59-
The build logic is defined using [Dagger](https://dagger.io/) [here](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/pipelines/builds/python_connectors.py).
60-
It does not rely on a Dockerfile.
61-
62-
If you would like to patch our connector and build your own a simple approach would be to:
63-
64-
1. Create your own Dockerfile based on the latest version of the connector image.
65-
```Dockerfile
66-
FROM airbyte/source-amplitude:latest
67-
68-
COPY . ./airbyte/integration_code
69-
RUN pip install ./airbyte/integration_code
70-
71-
# The entrypoint and default env vars are already set in the base image
72-
# ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
73-
# ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
36+
### Running unit tests
37+
To run unit tests locally, from the connector directory run:
38+
```
39+
poetry run pytest unit_tests
7440
```
75-
Please use this as an example. This is not optimized.
7641

77-
2. Build your image:
42+
### Building the docker image
43+
1. Install [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md)
44+
2. Run the following command to build the docker image:
7845
```bash
79-
docker build -t airbyte/source-amplitude:dev .
80-
# Running the spec command against your patched connector
81-
docker run airbyte/source-amplitude:dev spec
46+
airbyte-ci connectors --name=source-amplitude build
8247
```
83-
#### Run
48+
49+
An image will be available on your host with the tag `airbyte/source-amplitude:dev`.
50+
51+
52+
### Running as a docker container
8453
Then run any of the connector commands as follows:
8554
```
8655
docker run --rm airbyte/source-amplitude:dev spec
@@ -89,29 +58,34 @@ docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-amplitude:dev discover
8958
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-amplitude:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
9059
```
9160

92-
## Testing
61+
### Running our CI test suite
9362
You can run our full test suite locally using [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md):
9463
```bash
9564
airbyte-ci connectors --name=source-amplitude test
9665
```
9766

9867
### Customizing acceptance Tests
99-
Customize `acceptance-test-config.yml` file to configure tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
68+
Customize `acceptance-test-config.yml` file to configure acceptance tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
10069
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
10170

102-
## Dependency Management
103-
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
104-
We split dependencies between two groups, dependencies that are:
105-
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
106-
* required for the testing need to go to `TEST_REQUIREMENTS` list
71+
### Dependency Management
72+
All of your dependencies should be managed via Poetry.
73+
To add a new dependency, run:
74+
```bash
75+
poetry add <package-name>
76+
```
77+
78+
Please commit the changes to `pyproject.toml` and `poetry.lock` files.
10779

108-
### Publishing a new version of the connector
80+
## Publishing a new version of the connector
10981
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
11082
1. Make sure your changes are passing our test suite: `airbyte-ci connectors --name=source-amplitude test`
111-
2. Bump the connector version in `metadata.yaml`: increment the `dockerImageTag` value. Please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors).
83+
2. Bump the connector version (please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors)):
84+
- bump the `dockerImageTag` value in in `metadata.yaml`
85+
- bump the `version` value in `pyproject.toml`
11286
3. Make sure the `metadata.yaml` content is up to date.
113-
4. Make the connector documentation and its changelog is up to date (`docs/integrations/sources/amplitude.md`).
87+
4. Make sure the connector documentation and its changelog is up to date (`docs/integrations/sources/amplitude.md`).
11488
5. Create a Pull Request: use [our PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention).
11589
6. Pat yourself on the back for being an awesome contributor.
11690
7. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.
117-
91+
8. Once your PR is merged, the new version of the connector will be automatically published to Docker Hub and our connector registry.

airbyte-integrations/connectors/source-amplitude/metadata.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ data:
1111
connectorSubtype: api
1212
connectorType: source
1313
definitionId: fa9f58c6-2d03-4237-aaa4-07d75e0c1396
14-
dockerImageTag: 0.3.6
14+
dockerImageTag: 0.3.7
1515
dockerRepository: airbyte/source-amplitude
1616
documentationUrl: https://docs.airbyte.com/integrations/sources/amplitude
1717
githubIssueLabel: source-amplitude

0 commit comments

Comments
 (0)