Skip to content

Commit 1d5974a

Browse files
midavadimjatinyadav-cc
authored andcommitted
🚨🚨🐛 Source Gitlab fix merge_request_commits stream (airbytehq#34548)
1 parent 2c1d69f commit 1d5974a

File tree

16 files changed

+248
-248
lines changed

16 files changed

+248
-248
lines changed

airbyte-integrations/connectors/source-gitlab/acceptance-test-config.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ acceptance_tests:
1818
tests:
1919
- config_path: "secrets/config.json"
2020
backward_compatibility_tests_config:
21-
disable_for_version: 1.8.4
21+
disable_for_version: 3.0.0
2222
basic_read:
2323
tests:
2424
- config_path: "secrets/config.json"
@@ -29,6 +29,11 @@ acceptance_tests:
2929
jobs:
3030
- name: "user"
3131
bypass_reason: "User object contains local_time which will be different each time test is run"
32+
projects:
33+
- name: "updated_at"
34+
bypass_reason: "value can be changed"
35+
- name: "code_suggestions"
36+
bypass_reason: "value can be changed"
3237
- config_path: "secrets/config_with_ids.json"
3338
timeout_seconds: 3600
3439
empty_streams:
@@ -42,6 +47,11 @@ acceptance_tests:
4247
jobs:
4348
- name: "user"
4449
bypass_reason: "User object contains local_time which will be different each time test is run"
50+
projects:
51+
- name: "updated_at"
52+
bypass_reason: "value can be changed"
53+
- name: "code_suggestions"
54+
bypass_reason: "value can be changed"
4555
- config_path: "secrets/config_oauth.json"
4656
timeout_seconds: 3600
4757
expect_records:
@@ -50,6 +60,11 @@ acceptance_tests:
5060
jobs:
5161
- name: "user"
5262
bypass_reason: "User object contains local_time which will be different each time test is run"
63+
projects:
64+
- name: "updated_at"
65+
bypass_reason: "value can be changed"
66+
- name: "code_suggestions"
67+
bypass_reason: "value can be changed"
5368
incremental:
5469
tests:
5570
- config_path: "secrets/config_with_ids.json"

airbyte-integrations/connectors/source-gitlab/integration_tests/expected_records.jsonl

Lines changed: 25 additions & 30 deletions
Large diffs are not rendered by default.

airbyte-integrations/connectors/source-gitlab/integration_tests/expected_records_with_ids.jsonl

Lines changed: 21 additions & 26 deletions
Large diffs are not rendered by default.

airbyte-integrations/connectors/source-gitlab/metadata.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ data:
1010
connectorSubtype: api
1111
connectorType: source
1212
definitionId: 5e6175e5-68e1-4c17-bff9-56103bbb0d80
13-
dockerImageTag: 2.1.2
13+
dockerImageTag: 3.0.0
1414
dockerRepository: airbyte/source-gitlab
1515
documentationUrl: https://docs.airbyte.com/integrations/sources/gitlab
1616
githubIssueLabel: source-gitlab
@@ -29,6 +29,14 @@ data:
2929
releaseStage: generally_available
3030
releases:
3131
breakingChanges:
32+
3.0.0:
33+
message:
34+
In this release, merge_request_commits stream schema has been fixed so that it returns commits for each merge_request.
35+
Users will need to refresh the source schema and reset merge_request_commits stream after upgrading.
36+
upgradeDeadline: "2024-02-13"
37+
scopedImpact:
38+
- scopeType: stream
39+
impactedScopes: ["merge_request_commits"]
3240
2.0.0:
3341
message:
3442
In this release, several streams were updated to date-time field format, as declared in the Gitlab API.

airbyte-integrations/connectors/source-gitlab/source_gitlab/config_migrations.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,10 @@ def migrate(cls, args: List[str], source: SourceGitlab) -> None:
9595

9696

9797
class MigrateGroups(MigrateStringToArray):
98-
9998
migrate_from_key: str = "groups"
10099
migrate_to_key: str = "groups_list"
101100

102101

103102
class MigrateProjects(MigrateStringToArray):
104-
105103
migrate_from_key: str = "projects"
106104
migrate_to_key: str = "projects_list"

airbyte-integrations/connectors/source-gitlab/source_gitlab/schemas/epic_issues.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,12 @@
216216
},
217217
"group_id": {
218218
"type": ["null", "integer"]
219+
},
220+
"human_readable_end_date": {
221+
"type": ["null", "string"]
222+
},
223+
"human_readable_timestamp": {
224+
"type": ["null", "string"]
219225
}
220226
}
221227
},

airbyte-integrations/connectors/source-gitlab/source_gitlab/schemas/groups.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@
3838
}
3939
}
4040
}
41+
},
42+
"allowed_to_push": {
43+
"type": ["null", "array"],
44+
"items": {
45+
"type": ["null", "object"],
46+
"properties": {
47+
"access_level": {
48+
"type": ["null", "integer"]
49+
}
50+
}
51+
}
4152
}
4253
}
4354
},
@@ -74,6 +85,9 @@
7485
"subgroup_creation_level": {
7586
"type": ["null", "string"]
7687
},
88+
"enabled_git_access_protocol": {
89+
"type": ["null", "string"]
90+
},
7791
"emails_disabled": {
7892
"type": ["null", "boolean"]
7993
},
@@ -153,6 +167,12 @@
153167
},
154168
"service_access_tokens_expiration_enforced": {
155169
"type": ["null", "boolean"]
170+
},
171+
"lock_math_rendering_limits_enabled": {
172+
"type": ["null", "boolean"]
173+
},
174+
"math_rendering_limits_enabled": {
175+
"type": ["null", "boolean"]
156176
}
157177
}
158178
}

airbyte-integrations/connectors/source-gitlab/source_gitlab/schemas/issues.json

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,9 @@
118118
},
119119
"id": {
120120
"type": ["null", "integer"]
121+
},
122+
"locked": {
123+
"type": ["null", "boolean"]
121124
}
122125
}
123126
},
@@ -141,6 +144,12 @@
141144
},
142145
"username": {
143146
"type": ["null", "string"]
147+
},
148+
"id": {
149+
"type": ["null", "integer"]
150+
},
151+
"locked": {
152+
"type": ["null", "boolean"]
144153
}
145154
}
146155
},
@@ -164,6 +173,18 @@
164173
},
165174
"username": {
166175
"type": ["null", "string"]
176+
},
177+
"human_readable_end_date": {
178+
"type": ["null", "string"]
179+
},
180+
"human_readable_timestamp": {
181+
"type": ["null", "string"]
182+
},
183+
"id": {
184+
"type": ["null", "integer"]
185+
},
186+
"locked": {
187+
"type": ["null", "boolean"]
167188
}
168189
}
169190
},
@@ -251,6 +272,15 @@
251272
},
252273
"group_id": {
253274
"type": ["null", "integer"]
275+
},
276+
"locked": {
277+
"type": ["null", "boolean"]
278+
},
279+
"human_readable_end_date": {
280+
"type": ["null", "string"]
281+
},
282+
"human_readable_timestamp": {
283+
"type": ["null", "string"]
254284
}
255285
}
256286
},

0 commit comments

Comments
 (0)