Skip to content
This repository was archived by the owner on May 11, 2022. It is now read-only.

Commit c517aa8

Browse files
committed
issue #12: add optional id for entities
1 parent 7b67908 commit c517aa8

File tree

10 files changed

+305
-265
lines changed

10 files changed

+305
-265
lines changed

api/openapi-spec/v1.json

+9-9
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"SourceNodeMeta": {
3030
"type": "object",
3131
"properties": {
32-
"desc": {
32+
"description": {
3333
"type": "string"
3434
},
3535
"name": {
@@ -50,7 +50,7 @@
5050
"type": "string",
5151
"format": "date-time"
5252
},
53-
"desc": {
53+
"description": {
5454
"type": "string"
5555
},
5656
"emoji": {
@@ -87,7 +87,7 @@
8787
"type": "string",
8888
"format": "date-time"
8989
},
90-
"desc": {
90+
"description": {
9191
"type": "string"
9292
},
9393
"emoji": {
@@ -127,7 +127,7 @@
127127
"type": "string",
128128
"format": "date-time"
129129
},
130-
"desc": {
130+
"description": {
131131
"type": "string"
132132
},
133133
"emoji": {
@@ -154,7 +154,7 @@
154154
"$ref": "#/definitions/v1BatchRequestColumn"
155155
}
156156
},
157-
"desc": {
157+
"description": {
158158
"type": "string"
159159
},
160160
"emoji": {
@@ -180,7 +180,7 @@
180180
"v1BatchRequestCard": {
181181
"type": "object",
182182
"properties": {
183-
"desc": {
183+
"description": {
184184
"type": "string"
185185
},
186186
"emoji": {
@@ -209,7 +209,7 @@
209209
"$ref": "#/definitions/v1BatchRequestCard"
210210
}
211211
},
212-
"desc": {
212+
"description": {
213213
"type": "string"
214214
},
215215
"emoji": {
@@ -301,7 +301,7 @@
301301
"v1Source": {
302302
"type": "object",
303303
"properties": {
304-
"desc": {
304+
"description": {
305305
"type": "string"
306306
},
307307
"id": {
@@ -353,7 +353,7 @@
353353
"v1Vendor": {
354354
"type": "object",
355355
"properties": {
356-
"desc": {
356+
"description": {
357357
"type": "string"
358358
},
359359
"id": {

api/openapi-spec/v2.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"type": "string",
4040
"format": "date-time"
4141
},
42-
"desc": {
42+
"description": {
4343
"type": "string"
4444
},
4545
"emoji": {
@@ -76,7 +76,7 @@
7676
"type": "string",
7777
"format": "date-time"
7878
},
79-
"desc": {
79+
"description": {
8080
"type": "string"
8181
},
8282
"emoji": {
@@ -116,7 +116,7 @@
116116
"type": "string",
117117
"format": "date-time"
118118
},
119-
"desc": {
119+
"description": {
120120
"type": "string"
121121
},
122122
"emoji": {
@@ -153,7 +153,7 @@
153153
"v1Source": {
154154
"type": "object",
155155
"properties": {
156-
"desc": {
156+
"description": {
157157
"type": "string"
158158
},
159159
"id": {

api/protobuf-spec/v1/service.proto

+23-19
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ message BatchRequest {
3232
message Board {
3333
string title = 1;
3434
string emoji = 2;
35-
string desc = 3;
35+
string description = 3;
3636

3737
repeated Column columns = 4;
3838
repeated Filter filters = 5;
@@ -42,15 +42,15 @@ message BatchRequest {
4242
message Column {
4343
string title = 1;
4444
string emoji = 2;
45-
string desc = 3;
45+
string description = 3;
4646

4747
repeated Card cards = 4;
4848
}
4949

5050
message Card {
5151
string title = 1;
5252
string emoji = 2;
53-
string desc = 3;
53+
string description = 3;
5454
string url = 4;
5555
repeated string labels = 5;
5656
}
@@ -88,17 +88,19 @@ message BatchResponse {
8888
message Criteria {}
8989

9090
message NewBoard {
91-
string title = 1;
92-
string emoji = 2;
93-
string desc = 3;
91+
URI id = 1;
92+
93+
string title = 2;
94+
string emoji = 3;
95+
string description = 4;
9496
}
9597

9698
message Board {
9799
URI id = 1;
98100

99101
string title = 2;
100102
string emoji = 3;
101-
string desc = 4;
103+
string description = 4;
102104

103105
repeated Column columns = 5;
104106
repeated Filter filters = 6;
@@ -113,19 +115,20 @@ message BoardList {
113115
}
114116

115117
message NewColumn {
116-
URI board_id = 1;
118+
URI id = 1;
119+
URI board_id = 2;
117120

118-
string title = 2;
119-
string emoji = 3;
120-
string desc = 4;
121+
string title = 3;
122+
string emoji = 4;
123+
string description = 5;
121124
}
122125

123126
message Column {
124127
URI id = 1;
125128

126129
string title = 3;
127130
string emoji = 4;
128-
string desc = 5;
131+
string description = 5;
129132

130133
repeated Card cards = 6;
131134

@@ -134,21 +137,22 @@ message Column {
134137
}
135138

136139
message NewCard {
137-
URI column_id = 1;
140+
URI id = 1;
141+
URI column_id = 2;
138142

139-
string title = 2;
140-
string emoji = 3;
141-
string desc = 4;
142-
string url = 5;
143-
repeated string labels = 6;
143+
string title = 3;
144+
string emoji = 4;
145+
string description = 5;
146+
string url = 6;
147+
repeated string labels = 7;
144148
}
145149

146150
message Card {
147151
URI id = 1;
148152

149153
string title = 3;
150154
string emoji = 4;
151-
string desc = 5;
155+
string description = 5;
152156
string url = 6;
153157
repeated string labels = 7;
154158

api/protobuf-spec/v1/vendor.proto

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ service VendorService {
2121
message Secret {
2222
string token = 1;
2323
string name = 2;
24-
string desc = 3;
24+
string description = 3;
2525
Provider provider = 4;
2626
}
2727

2828
message Vendor {
2929
URI id = 1;
3030
string name = 2;
31-
string desc = 3;
31+
string description = 3;
3232
Provider type = 4;
3333
}
3434

@@ -39,7 +39,7 @@ message VendorList {
3939
message Source {
4040
URI id = 1;
4141
string name = 2;
42-
string desc = 3;
42+
string description = 3;
4343
}
4444

4545
message SourceList {
@@ -49,7 +49,7 @@ message SourceList {
4949
message SourceNode {
5050
message Meta {
5151
string name = 1;
52-
string desc = 2;
52+
string description = 2;
5353
}
5454

5555
Meta meta = 1;

env/docker/storage/context/initdb.d/prototype.sql

+4
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ CREATE TABLE "column"
2626
"deleted_at" TIMESTAMP NULL DEFAULT NULL
2727
);
2828

29+
-- TODO:debt add
30+
-- - string url
31+
-- - repeated string labels
32+
2933
CREATE TABLE "card"
3034
(
3135
"id" UUID NOT NULL PRIMARY KEY DEFAULT uuid_generate_v4(),

0 commit comments

Comments
 (0)