fix: urls structure

Author: SKairinos

codeforlife/tests/api.py

@@ -338,7 +338,7 @@ def generic(
         assert status_code_assertion(
             status_code
         ), f"Unexpected status code: {status_code}." + (
-            "\nValidation errors:: "
+            "\nValidation errors: "
             + json.dumps(
                 # pylint: disable-next=no-member
                 response.json(),  # type: ignore[attr-defined]

codeforlife/urls/__init__.py

@@ -0,0 +1,7 @@
+"""
+© Ocado Group
+Created on 16/09/2024 at 15:23:05(+01:00).
+"""
+
+from .handlers import handler400, handler403, handler404, handler500
+from .patterns import get_urlpatterns

codeforlife/urls/handlers.py

@@ -0,0 +1,21 @@
+"""
+© Ocado Group
+Created on 16/09/2024 at 15:19:54(+01:00).
+
+Custom error handlers which override django's default behavior to render a
+template.
+
+https://docs.djangoproject.com/en/3.2/ref/urls/#module-django.conf.urls
+"""
+
+from django.http import (
+    HttpResponseBadRequest,
+    HttpResponseForbidden,
+    HttpResponseNotFound,
+    HttpResponseServerError,
+)
+
+handler400 = lambda request: HttpResponseBadRequest()
+handler403 = lambda request: HttpResponseForbidden()
+handler404 = lambda request: HttpResponseNotFound()
+handler500 = lambda request: HttpResponseServerError()

codeforlife/urls.py renamed to codeforlife/urls/patterns.py

@@ -6,18 +6,12 @@
 import typing as t
 
 from django.contrib import admin
-from django.http import (
-    HttpResponse,
-    HttpResponseBadRequest,
-    HttpResponseForbidden,
-    HttpResponseNotFound,
-    HttpResponseServerError,
-)
+from django.http import HttpResponse
 from django.urls import URLPattern, URLResolver, include, path, re_path
 from rest_framework import status
 
-from .settings import SERVICE_IS_ROOT, SERVICE_NAME
-from .views import CsrfCookieView, LogoutView
+from ..settings import SERVICE_IS_ROOT, SERVICE_NAME
+from ..views import CsrfCookieView, LogoutView
 
 UrlPatterns = t.List[t.Union[URLResolver, URLPattern]]
 
@@ -99,11 +93,3 @@ def get_urlpatterns(
             name="service-not-found",
         ),
     ]
-
-
-# Error handlers.
-# https://docs.djangoproject.com/en/3.2/ref/urls/#module-django.conf.urls
-handler400 = lambda request: HttpResponseBadRequest()
-handler403 = lambda request: HttpResponseForbidden()
-handler404 = lambda request: HttpResponseNotFound()
-handler500 = lambda request: HttpResponseServerError()