Skip to content

lock is removed even when slack notification times out #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsirianni opened this issue Jun 29, 2018 · 3 comments
Closed

lock is removed even when slack notification times out #5

jsirianni opened this issue Jun 29, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jsirianni
Copy link
Member

jsirianni commented Jun 29, 2018

edit: see comments for root cause

While testing a freebsd implementation, I noticed slack notifications tended to lag a big.. which caused a timeout. The lock file was removed, despite the failed alert.

Disk usage healthy: /
Lock removed
dial tcp: i/o timeout
Failed to send alert!
root@fw-prod:~ # 
root@fw-prod:~ # 
root@fw-prod:~ # 
root@fw-prod:~ # ./disk-usage-bsd.bin -t 70 -c alerts -slack-url https://hooks.slack.com/services/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
@jsirianni jsirianni added enhancement New feature or request good first issue Good for newcomers labels Jun 29, 2018
@jsirianni jsirianni self-assigned this Jun 29, 2018
@jsirianni
Copy link
Member Author

The timeout seems to only occur when removing the lock

@jsirianni
Copy link
Member Author

When replicating the issue on linux, I get the following error.

dial tcp: lookup smtp.domain.localnet on 10.1.30.2:53: no such host

Turns out, I was not passing -s for enabling slack. We should set slack to true if a url is passed, and possible remove the -s flag entirely.

@jsirianni
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant