Skip to content

Commit 300d7d4

Browse files
authored
Update cache keys in test-inputs.yml (#79)
It's always caching. Or DNS. This time it was caching. A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing. We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass? It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing. This is what broke CI for #77. This PR will fix it.
1 parent c730648 commit 300d7d4

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/test-inputs.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,9 @@ jobs:
286286
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
287287
fail-on-cache-miss: true
288288
lookup-only: true
289-
key: -${{ github.job }}
289+
key: semver-${{ github.job }}
290290
restore-keys: |
291-
-${{ github.job }}
291+
semver-${{ github.job }}
292292
- name: Fail if the toolchain used by the action is invalid
293293
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
294294
run: |
@@ -329,9 +329,9 @@ jobs:
329329
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
330330
fail-on-cache-miss: true
331331
lookup-only: true
332-
key: -${{ github.job }}
332+
key: semver-${{ github.job }}
333333
restore-keys: |
334-
-${{ github.job }}
334+
semver-${{ github.job }}
335335
- name: Fail if the toolchain used by the action is invalid
336336
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'nightly') }}
337337
run: |
@@ -372,9 +372,9 @@ jobs:
372372
path: ${{ github.workspace }}/semver-checks/target/semver-checks/cache
373373
fail-on-cache-miss: true
374374
lookup-only: true
375-
key: -${{ github.job }}
375+
key: semver-${{ github.job }}
376376
restore-keys: |
377-
-${{ github.job }}
377+
semver-${{ github.job }}
378378
- name: Fail if the toolchain used by the action is invalid
379379
if: ${{ ! contains(steps.get-cache-key.outputs.cache-matched-key, 'beta') }}
380380
run: |

0 commit comments

Comments
 (0)