separate the actor into two

Author: PeterMocary

repos/system_upgrade/common/actors/checkdynamiclinkerconfiguration/actor.py

@@ -0,0 +1,22 @@
+from leapp.actors import Actor
+from leapp.libraries.actor.checkdynamiclinkerconfiguration import check_dynamic_linker_configuration
+from leapp.models import DynamicLinkerConfiguration, Report
+from leapp.tags import ChecksPhaseTag, IPUWorkflowTag
+
+
+class CheckDynamicLinkerConfiguration(Actor):
+    """
+    Check for customization of dynamic linker configuration.
+
+    The in-place upgrade could potentionally be impacted in a negative way due
+    to the customization of dynamic linker configuration by user. This actor creates high
+    severity report upon detecting such customization.
+    """
+
+    name = 'check_dynamic_linker_configuration'
+    consumes = (DynamicLinkerConfiguration,)
+    produces = (Report,)
+    tags = (ChecksPhaseTag, IPUWorkflowTag)
+
+    def process(self):
+        check_dynamic_linker_configuration()

repos/system_upgrade/common/actors/checkdynamiclinkerconfiguration/libraries/checkdynamiclinkerconfiguration.py

@@ -0,0 +1,70 @@
+from leapp import reporting
+from leapp.libraries.stdlib import api
+from leapp.models import DynamicLinkerConfiguration
+
+LD_SO_CONF_DIR = '/etc/ld.so.conf.d'
+LD_SO_CONF_MAIN = '/etc/ld.so.conf'
+LD_LIBRARY_PATH_VAR = 'LD_LIBRARY_PATH'
+LD_PRELOAD_VAR = 'LD_PRELOAD'
+FMT_LIST_SEPARATOR_1 = '\n- '
+FMT_LIST_SEPARATOR_2 = '\n    - '
+
+
+def _report_custom_dynamic_linker_configuration(summary):
+    reporting.create_report([
+        reporting.Title(
+            'Detected customized configuration for dynamic linker.'
+        ),
+        reporting.Summary(summary),
+        reporting.Remediation(hint=('Remove or revert the custom dynamic linker configurations and apply the changes '
+                                    'using the ldconfig command. In case of possible active software collections we '
+                                    'suggest disabling them persistently.')),
+        reporting.RelatedResource('file', '/etc/ld.so.conf'),
+        reporting.RelatedResource('directory', '/etc/ld.so.conf.d'),
+        reporting.Severity(reporting.Severity.HIGH),
+        reporting.Groups([reporting.Groups.OS_FACTS]),
+    ])
+
+
+def check_dynamic_linker_configuration():
+    configuration = next(api.consume(DynamicLinkerConfiguration), None)
+    if not configuration:
+        return
+
+    custom_configurations = ''
+    if configuration.main_config.modified:
+        custom_configurations += (
+            '{}The {} file has unexpected contents:{}{}'
+            .format(FMT_LIST_SEPARATOR_1, LD_SO_CONF_MAIN,
+                    FMT_LIST_SEPARATOR_2, FMT_LIST_SEPARATOR_2.join(configuration.main_config.modified_lines))
+        )
+
+    custom_configs = []
+    for config in configuration.included_configs:
+        if config.modified:
+            custom_configs.append(config.path)
+
+    if custom_configs:
+        custom_configurations += (
+            '{}The following drop in config files were marked as custom:{}{}'
+            .format(FMT_LIST_SEPARATOR_1, FMT_LIST_SEPARATOR_2, FMT_LIST_SEPARATOR_2.join(custom_configs))
+        )
+
+    if configuration.used_variables:
+        custom_configurations += (
+            '{}The following variables contain unexpected dynamic linker configuration:{}{}'
+            .format(FMT_LIST_SEPARATOR_1, FMT_LIST_SEPARATOR_2,
+                    FMT_LIST_SEPARATOR_2.join(configuration.used_variables))
+        )
+
+    if custom_configurations:
+        summary = (
+            'Custom configurations to the dynamic linker could potentially impact the upgrade in a negative '
+            'way. The custom configuration includes modifications to {}, custom or modified drop in config '
+            'files in the {} directory and additional entries in the {} or {} variables. These modifications '
+            'configure the dynamic linker to use different libraries that might not be provided by Red Hat '
+            'products or might not be present during the whole upgrade process. The following custom '
+            'configurations were detected by leapp:{}'
+            .format(LD_SO_CONF_MAIN, LD_SO_CONF_DIR, LD_LIBRARY_PATH_VAR, LD_PRELOAD_VAR, custom_configurations)
+        )
+        _report_custom_dynamic_linker_configuration(summary)

repos/system_upgrade/common/actors/checkdynamiclinkerconfiguration/tests/test_checkdynamiclinkerconfiguration.py

@@ -0,0 +1,65 @@
+import pytest
+
+from leapp import reporting
+from leapp.libraries.actor.checkdynamiclinkerconfiguration import (
+    check_dynamic_linker_configuration,
+    LD_LIBRARY_PATH_VAR,
+    LD_PRELOAD_VAR
+)
+from leapp.libraries.common.testutils import create_report_mocked, CurrentActorMocked
+from leapp.libraries.stdlib import api
+from leapp.models import ConfigFile, DynamicLinkerConfiguration, MainConfigFile
+
+INCLUDED_CONFIG_PATHS = ['/etc/ld.so.conf.d/dyninst-x86_64.conf',
+                         '/etc/ld.so.conf.d/mariadb-x86_64.conf',
+                         '/custom/path/custom1.conf']
+
+
+@pytest.mark.parametrize(('included_configs_modifications', 'used_variables', 'modified_lines'),
+                         [
+                            ([False, False, False], [], []),
+                            ([True, True, True], [], []),
+                            ([False, False, False], [LD_LIBRARY_PATH_VAR], []),
+                            ([False, False, False], [], ['modified line 1', 'midified line 2']),
+                            ([True, False, True], [LD_LIBRARY_PATH_VAR, LD_PRELOAD_VAR], ['modified line']),
+                        ])
+def test_check_ld_so_configuration(monkeypatch, included_configs_modifications, used_variables, modified_lines):
+    assert len(INCLUDED_CONFIG_PATHS) == len(included_configs_modifications)
+
+    main_config = MainConfigFile(path="/etc/ld.so.conf", modified=any(modified_lines), modified_lines=modified_lines)
+    included_configs = []
+    for path, modified in zip(INCLUDED_CONFIG_PATHS, included_configs_modifications):
+        included_configs.append(ConfigFile(path=path, modified=modified))
+
+    configuration = DynamicLinkerConfiguration(main_config=main_config,
+                                               included_configs=included_configs,
+                                               used_variables=used_variables)
+
+    monkeypatch.setattr(api, 'current_actor', CurrentActorMocked(msgs=[configuration]))
+    monkeypatch.setattr(reporting, 'create_report', create_report_mocked())
+
+    check_dynamic_linker_configuration()
+
+    report_expected = any(included_configs_modifications) or modified_lines or used_variables
+    if not report_expected:
+        assert reporting.create_report.called == 0
+        return
+
+    assert reporting.create_report.called == 1
+    assert 'configuration for dynamic linker' in reporting.create_report.reports[0]['title']
+    summary = reporting.create_report.reports[0]['summary']
+
+    if any(included_configs_modifications):
+        assert 'The following drop in config files were marked as custom:' in summary
+    for config, modified in zip(INCLUDED_CONFIG_PATHS, included_configs_modifications):
+        assert modified == (config in summary)
+
+    if modified_lines:
+        assert 'The /etc/ld.so.conf file has unexpected contents' in summary
+    for line in modified_lines:
+        assert line in summary
+
+    if used_variables:
+        assert 'The following variables contain unexpected dynamic linker configuration:' in summary
+    for var in used_variables:
+        assert '- {}'.format(var) in summary

repos/system_upgrade/common/actors/checkldsoconf/actor.py

@@ -0,0 +1,23 @@
+from leapp.actors import Actor
+from leapp.libraries.actor.scandynamiclinkerconfiguration import scan_dynamic_linker_configuration
+from leapp.models import DynamicLinkerConfiguration, InstalledRedHatSignedRPM
+from leapp.tags import FactsPhaseTag, IPUWorkflowTag
+
+
+class ScanDynamicLinkerConfiguration(Actor):
+    """
+    Scan the dynamoc linker configuration and find modifications.
+
+    The dynamic linker configuration files can be used to replace standard libraries
+    with different custom libraries. The in-place upgrade does not support customization
+    of this configuration by user. This actor produces information about detected
+    modifications.
+    """
+
+    name = 'scan_dynamic_linker_configuration'
+    consumes = (InstalledRedHatSignedRPM,)
+    produces = (DynamicLinkerConfiguration,)
+    tags = (FactsPhaseTag, IPUWorkflowTag)
+
+    def process(self):
+        scan_dynamic_linker_configuration()