Skip to content

As a developer, I should be able to verify if a given data, hash pair are a valid verification key. #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
45930 opened this issue Apr 2, 2025 · 1 comment
Labels
feature-request Issues that specify work that is requested by others

Comments

@45930
Copy link
Contributor

45930 commented Apr 2, 2025

See: https://discord.com/channels/484437221055922177/1357003022307295405

It would be convenient if the SDK exposed a way to verify the validity of a given string verification key hash. Ultimately, we would want to access this within a circuit, e.g. to upgrade a side-loaded verification key committed to on chain.

Deniz found that you can set any value for the verification key hash and the transaction will succeed on LocalBlockchain: https://github.com/0x471/o1js-vk-hash-validation/blob/main/README.md - This is a confusing DevX and we can improve it by validating in JS whether the pair is valid.

@45930 45930 added the feature-request Issues that specify work that is requested by others label Apr 2, 2025
@Trivo25
Copy link
Member

Trivo25 commented Apr 3, 2025

// Assert the validity of the auxiliary vk-data by comparing the witnessed and computed hash
const hash = inCircuitVkHash(circuitVk);

This might help, we check this implicitly internally already - I agree with adding an explicit way if possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Issues that specify work that is requested by others
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants