adds better exit code handling to lint and lint-style commands (#93)

Author: delambo

cli/actions/lint.js

@@ -1,9 +1,7 @@
 
 // Command to lint src code
 
-const path = require('path');
 const CLIEngine = require('eslint').CLIEngine;
-const shell = require('shelljs');
 const logger = require('./../logger');
 const glob = require('glob');
 const { userRootPath } = require('../../utils/paths')();
@@ -22,14 +20,16 @@ module.exports = () => {
     const cli = new CLIEngine(eslintCLI);
     const report = cli.executeOnFiles(files);
     const formatter = cli.getFormatter();
-    logger.log(formatter(report.results));
+    logger.log(`${formatter(report.results)}\n`);
+    process.exit(report.errorCount + report.warningCount > 0 ? 1 : 0);
   };
 
   // Check to see if eslint file exists
   const eslintrc = glob.sync(`${userRootPath}/.*eslintrc*`);
   if (!eslintrc.length) {
     logger.error('You do not have an eslintrc file in the root of your project');
-    process.exit();
+    process.exit(1);
   }
+
   lint();
 };

cli/actions/lintStyle.js

@@ -5,11 +5,15 @@ const glob = require('glob');
 const { userRootPath } = require('../../utils/paths')();
 
 module.exports = () => {
+  const handleError = (error) => {
+    logger.error(error);
+    process.exit(1);
+  };
+
   // Check to see if stylelint file exists
   const stylelintrc = glob.sync(`${userRootPath}/.stylelintrc`);
   if (!stylelintrc.length) {
-    logger.error('You do not have a .stylelintrc file in the root of your project');
-    process.exit();
+    handleError('You do not have a .stylelintrc file in the root of your project');
   }
 
   stylelint.lint({
@@ -18,13 +22,14 @@ module.exports = () => {
   })
   .then((result) => {
     if (result.output) {
-      logger.log(result.output);
+      handleError(`\n${result.output}`);
     } else {
       logger.log('');
       logger.end('Your styles look good! ✨\n');
+      process.exit(0);
     }
   })
-  .catch((err) => {
-    logger.error(err.stack);
+  .catch((error) => {
+    handleError(error.stack);
   });
 };