Skip to content

Commit 6c776f5

Browse files
committed
Update to aws-sdk-go-v2
1 parent 76fe65f commit 6c776f5

File tree

5 files changed

+103
-49
lines changed

5 files changed

+103
-49
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ jobs:
3838
- name: Install Linux packages
3939
run: sudo apt install -y --no-install-recommends pandoc
4040

41+
- name: Install and start DynamoDB
42+
uses: rrainn/[email protected]
43+
4144
- name: Install Go
4245
uses: actions/setup-go@v5
4346
with:

go.mod

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ module github.com/nyaruka/gocommon
33
go 1.22
44

55
require (
6-
github.com/aws/aws-sdk-go v1.55.3
6+
github.com/aws/aws-sdk-go-v2 v1.30.4
7+
github.com/aws/aws-sdk-go-v2/config v1.27.28
8+
github.com/aws/aws-sdk-go-v2/credentials v1.17.28
9+
github.com/aws/aws-sdk-go-v2/service/s3 v1.60.0
710
github.com/gabriel-vasile/mimetype v1.4.5
811
github.com/go-chi/chi/v5 v5.1.0
912
github.com/go-playground/validator/v10 v10.22.0
@@ -24,10 +27,23 @@ require (
2427
)
2528

2629
require (
30+
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.4 // indirect
31+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.12 // indirect
32+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.16 // indirect
33+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.16 // indirect
34+
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
35+
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.16 // indirect
36+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.4 // indirect
37+
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.18 // indirect
38+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.18 // indirect
39+
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.16 // indirect
40+
github.com/aws/aws-sdk-go-v2/service/sso v1.22.5 // indirect
41+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.5 // indirect
42+
github.com/aws/aws-sdk-go-v2/service/sts v1.30.4 // indirect
43+
github.com/aws/smithy-go v1.20.4 // indirect
2744
github.com/davecgh/go-spew v1.1.1 // indirect
2845
github.com/go-playground/locales v0.14.1 // indirect
2946
github.com/go-playground/universal-translator v0.18.1 // indirect
30-
github.com/jmespath/go-jmespath v0.4.0 // indirect
3147
github.com/leodido/go-urn v1.4.0 // indirect
3248
github.com/pmezard/go-difflib v1.0.0 // indirect
3349
golang.org/x/crypto v0.25.0 // indirect

go.sum

Lines changed: 36 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,41 @@
11
filippo.io/edwards25519 v1.1.0 h1:FNf4tywRC1HmFuKW5xopWpigGjJKiJSV0Cqo0cJWDaA=
22
filippo.io/edwards25519 v1.1.0/go.mod h1:BxyFTGdWcka3PhytdK4V28tE5sGfRvvvRV7EaN4VDT4=
3-
github.com/aws/aws-sdk-go v1.55.3 h1:0B5hOX+mIx7I5XPOrjrHlKSDQV/+ypFZpIHOx5LOk3E=
4-
github.com/aws/aws-sdk-go v1.55.3/go.mod h1:eRwEWoyTWFMVYVQzKMNHWP5/RV4xIUGMQfXQHfHkpNU=
5-
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
3+
github.com/aws/aws-sdk-go-v2 v1.30.4 h1:frhcagrVNrzmT95RJImMHgabt99vkXGslubDaDagTk8=
4+
github.com/aws/aws-sdk-go-v2 v1.30.4/go.mod h1:CT+ZPWXbYrci8chcARI3OmI/qgd+f6WtuLOoaIA8PR0=
5+
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.4 h1:70PVAiL15/aBMh5LThwgXdSQorVr91L127ttckI9QQU=
6+
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.4/go.mod h1:/MQxMqci8tlqDH+pjmoLu1i0tbWCUP1hhyMRuFxpQCw=
7+
github.com/aws/aws-sdk-go-v2/config v1.27.28 h1:OTxWGW/91C61QlneCtnD62NLb4W616/NM1jA8LhJqbg=
8+
github.com/aws/aws-sdk-go-v2/config v1.27.28/go.mod h1:uzVRVtJSU5EFv6Fu82AoVFKozJi2ZCY6WRCXj06rbvs=
9+
github.com/aws/aws-sdk-go-v2/credentials v1.17.28 h1:m8+AHY/ND8CMHJnPoH7PJIRakWGa4gbfbxuY9TGTUXM=
10+
github.com/aws/aws-sdk-go-v2/credentials v1.17.28/go.mod h1:6TF7dSc78ehD1SL6KpRIPKMA1GyyWflIkjqg+qmf4+c=
11+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.12 h1:yjwoSyDZF8Jth+mUk5lSPJCkMC0lMy6FaCD51jm6ayE=
12+
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.12/go.mod h1:fuR57fAgMk7ot3WcNQfb6rSEn+SUffl7ri+aa8uKysI=
13+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.16 h1:TNyt/+X43KJ9IJJMjKfa3bNTiZbUP7DeCxfbTROESwY=
14+
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.16/go.mod h1:2DwJF39FlNAUiX5pAc0UNeiz16lK2t7IaFcm0LFHEgc=
15+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.16 h1:jYfy8UPmd+6kJW5YhY0L1/KftReOGxI/4NtVSTh9O/I=
16+
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.16/go.mod h1:7ZfEPZxkW42Afq4uQB8H2E2e6ebh6mXTueEpYzjCzcs=
17+
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 h1:VaRN3TlFdd6KxX1x3ILT5ynH6HvKgqdiXoTxAF4HQcQ=
18+
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1/go.mod h1:FbtygfRFze9usAadmnGJNc8KsP346kEe+y2/oyhGAGc=
19+
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.16 h1:mimdLQkIX1zr8GIPY1ZtALdBQGxcASiBd2MOp8m/dMc=
20+
github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.16/go.mod h1:YHk6owoSwrIsok+cAH9PENCOGoH5PU2EllX4vLtSrsY=
21+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.4 h1:KypMCbLPPHEmf9DgMGw51jMj77VfGPAN2Kv4cfhlfgI=
22+
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.4/go.mod h1:Vz1JQXliGcQktFTN/LN6uGppAIRoLBR2bMvIMP0gOjc=
23+
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.18 h1:GckUnpm4EJOAio1c8o25a+b3lVfwVzC9gnSBqiiNmZM=
24+
github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.18/go.mod h1:Br6+bxfG33Dk3ynmkhsW2Z/t9D4+lRqdLDNCKi85w0U=
25+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.18 h1:tJ5RnkHCiSH0jyd6gROjlJtNwov0eGYNz8s8nFcR0jQ=
26+
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.18/go.mod h1:++NHzT+nAF7ZPrHPsA+ENvsXkOO8wEu+C6RXltAG4/c=
27+
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.16 h1:jg16PhLPUiHIj8zYIW6bqzeQSuHVEiWnGA0Brz5Xv2I=
28+
github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.16/go.mod h1:Uyk1zE1VVdsHSU7096h/rwnXDzOzYQVl+FNPhPw7ShY=
29+
github.com/aws/aws-sdk-go-v2/service/s3 v1.60.0 h1:2QXGJvG19QwqXUvgcdoCOZPyLuvZf8LiXPCN4P53TdI=
30+
github.com/aws/aws-sdk-go-v2/service/s3 v1.60.0/go.mod h1:BSPI0EfnYUuNHPS0uqIo5VrRwzie+Fp+YhQOUs16sKI=
31+
github.com/aws/aws-sdk-go-v2/service/sso v1.22.5 h1:zCsFCKvbj25i7p1u94imVoO447I/sFv8qq+lGJhRN0c=
32+
github.com/aws/aws-sdk-go-v2/service/sso v1.22.5/go.mod h1:ZeDX1SnKsVlejeuz41GiajjZpRSWR7/42q/EyA/QEiM=
33+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.5 h1:SKvPgvdvmiTWoi0GAJ7AsJfOz3ngVkD/ERbs5pUnHNI=
34+
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.5/go.mod h1:20sz31hv/WsPa3HhU3hfrIet2kxM4Pe0r20eBZ20Tac=
35+
github.com/aws/aws-sdk-go-v2/service/sts v1.30.4 h1:iAckBT2OeEK/kBDyN/jDtpEExhjeeA/Im2q4X0rJZT8=
36+
github.com/aws/aws-sdk-go-v2/service/sts v1.30.4/go.mod h1:vmSqFK+BVIwVpDAGZB3CoCXHzurt4qBE8lf+I/kRTh0=
37+
github.com/aws/smithy-go v1.20.4 h1:2HK1zBdPgRbjFOHlfeQZfpC4r72MOb9bZkiFwggKO+4=
38+
github.com/aws/smithy-go v1.20.4/go.mod h1:irrKGvNn1InZwb2d7fkIRNucdfwR8R+Ts3wxYa/cJHg=
639
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
740
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
841
github.com/gabriel-vasile/mimetype v1.4.5 h1:J7wGKdGu33ocBOhGy0z653k/lFKLFDPJMG8Gql0kxn4=
@@ -27,10 +60,6 @@ github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aN
2760
github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
2861
github.com/jellydator/ttlcache/v3 v3.2.0 h1:6lqVJ8X3ZaUwvzENqPAobDsXNExfUJd61u++uW8a3LE=
2962
github.com/jellydator/ttlcache/v3 v3.2.0/go.mod h1:hi7MGFdMAwZna5n2tuvh63DvFLzVKySzCVW6+0gA2n4=
30-
github.com/jmespath/go-jmespath v0.4.0 h1:BEgLn5cpjn8UN1mAw4NjwDrS35OdebyEtFe+9YPoQUg=
31-
github.com/jmespath/go-jmespath v0.4.0/go.mod h1:T8mJZnbsbmF+m6zOOFylbeCJqk5+pHWvzYPziyZiYoo=
32-
github.com/jmespath/go-jmespath/internal/testify v1.5.1 h1:shLQSRRSCCPj3f2gpwzGwWFoC7ycTf1rcQZHOlsJ6N8=
33-
github.com/jmespath/go-jmespath/internal/testify v1.5.1/go.mod h1:L3OGu8Wl2/fWfCI6z80xFu9LTZmf1ZRjMHUOPmWr69U=
3463
github.com/jmoiron/sqlx v1.4.0 h1:1PLqN7S1UYp5t4SrVVnt4nUVNemrDAtxlulVe+Qgm3o=
3564
github.com/jmoiron/sqlx v1.4.0/go.mod h1:ZrZ7UsYB/weZdl2Bxg6jCRO9c3YHl8r3ahlKmRT4JLY=
3665
github.com/leodido/go-urn v1.4.0 h1:WT9HwE9SGECu3lg4d/dIA+jxlljEa1/ffXKmRjqdmIQ=
@@ -49,7 +78,6 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
4978
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
5079
github.com/shopspring/decimal v1.4.0 h1:bxl37RwXBklmTi0C79JfXCEBD1cqqHt0bbgBAGFp81k=
5180
github.com/shopspring/decimal v1.4.0/go.mod h1:gawqmDU56v4yIKSwfBSFip1HdCCXN8/+DMd9qYNcwME=
52-
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
5381
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
5482
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
5583
go.uber.org/goleak v1.2.1 h1:NBol2c7O1ZokfZ0LEU9K6Whx/KnwvepVetCUhtKja4A=
@@ -70,7 +98,5 @@ google.golang.org/protobuf v1.34.2 h1:6xV6lTsCfpGD21XK49h7MhtcApnLqkfYgPcdHftf6h
7098
google.golang.org/protobuf v1.34.2/go.mod h1:qYOHts0dSfpeUzUFpOMr/WGzszTmLH+DiWniOlNbLDw=
7199
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
72100
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
73-
gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
74-
gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
75101
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
76102
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

s3x/service.go

Lines changed: 37 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,30 @@ import (
88
"sync"
99
"time"
1010

11-
"github.com/aws/aws-sdk-go/aws"
12-
"github.com/aws/aws-sdk-go/aws/credentials"
13-
"github.com/aws/aws-sdk-go/aws/session"
14-
"github.com/aws/aws-sdk-go/service/s3"
11+
"github.com/aws/aws-sdk-go-v2/aws"
12+
"github.com/aws/aws-sdk-go-v2/config"
13+
"github.com/aws/aws-sdk-go-v2/credentials"
14+
"github.com/aws/aws-sdk-go-v2/service/s3"
15+
"github.com/aws/aws-sdk-go-v2/service/s3/types"
1516
)
1617

1718
// Service is simple abstraction layer to work with a S3-compatible storage service
1819
type Service struct {
19-
Client *s3.S3
20+
Client *s3.Client
2021
urler ObjectURLer
2122
}
2223

2324
// NewService creates a new S3 service with the given credentials and configuration
2425
func NewService(accessKey, secretKey, region, endpoint string, minio bool) (*Service, error) {
25-
cfg := &aws.Config{
26-
Region: aws.String(region),
27-
Endpoint: aws.String(endpoint),
28-
S3ForcePathStyle: aws.Bool(minio), // urls as endpoint/bucket/key instead of bucket.endpoint/key
29-
MaxRetries: aws.Int(3),
30-
}
31-
if accessKey != "" || secretKey != "" {
32-
cfg.Credentials = credentials.NewStaticCredentials(accessKey, secretKey, "")
26+
opts := []func(*config.LoadOptions) error{config.WithRegion(region)}
27+
28+
if accessKey != "" && secretKey != "" {
29+
opts = append(opts, config.WithCredentialsProvider(credentials.StaticCredentialsProvider{Value: aws.Credentials{
30+
AccessKeyID: accessKey, SecretAccessKey: secretKey,
31+
}}))
3332
}
34-
s, err := session.NewSession(cfg)
33+
34+
cfg, err := config.LoadDefaultConfig(context.TODO(), opts...)
3535
if err != nil {
3636
return nil, err
3737
}
@@ -43,7 +43,15 @@ func NewService(accessKey, secretKey, region, endpoint string, minio bool) (*Ser
4343
urler = AWSURLer(region)
4444
}
4545

46-
return &Service{Client: s3.New(s), urler: urler}, nil
46+
client := s3.NewFromConfig(cfg, func(o *s3.Options) {
47+
o.UsePathStyle = minio // urls as endpoint/bucket/key instead of bucket.endpoint/key
48+
49+
if endpoint != "" {
50+
o.BaseEndpoint = aws.String(endpoint)
51+
}
52+
})
53+
54+
return &Service{Client: client, urler: urler}, nil
4755
}
4856

4957
// ObjectURL returns the publicly accessible URL for the given object
@@ -53,13 +61,13 @@ func (s *Service) ObjectURL(bucket, key string) string {
5361

5462
// Test is a convenience method to HEAD a bucket to test if it exists and we can access it
5563
func (s *Service) Test(ctx context.Context, bucket string) error {
56-
_, err := s.Client.HeadBucket(&s3.HeadBucketInput{Bucket: aws.String(bucket)})
64+
_, err := s.Client.HeadBucket(ctx, &s3.HeadBucketInput{Bucket: aws.String(bucket)})
5765
return err
5866
}
5967

6068
// GetObject is a convenience method to get an object from S3 and read its contents into a byte slice
6169
func (s *Service) GetObject(ctx context.Context, bucket, key string) (string, []byte, error) {
62-
out, err := s.Client.GetObjectWithContext(ctx, &s3.GetObjectInput{
70+
out, err := s.Client.GetObject(ctx, &s3.GetObjectInput{
6371
Bucket: aws.String(bucket),
6472
Key: aws.String(key),
6573
})
@@ -72,17 +80,17 @@ func (s *Service) GetObject(ctx context.Context, bucket, key string) (string, []
7280
return "", nil, fmt.Errorf("error reading S3 object: %w", err)
7381
}
7482

75-
return aws.StringValue(out.ContentType), body, nil
83+
return aws.ToString(out.ContentType), body, nil
7684
}
7785

7886
// PutObject is a convenience method to put the given object and return its publicly accessible URL
79-
func (s *Service) PutObject(ctx context.Context, bucket, key string, contentType string, body []byte, acl string) (string, error) {
80-
_, err := s.Client.PutObjectWithContext(ctx, &s3.PutObjectInput{
87+
func (s *Service) PutObject(ctx context.Context, bucket, key string, contentType string, body []byte, acl types.ObjectCannedACL) (string, error) {
88+
_, err := s.Client.PutObject(ctx, &s3.PutObjectInput{
8189
Bucket: aws.String(bucket),
8290
Body: bytes.NewReader(body),
8391
Key: aws.String(key),
8492
ContentType: aws.String(contentType),
85-
ACL: aws.String(acl),
93+
ACL: acl,
8694
})
8795
if err != nil {
8896
return "", fmt.Errorf("error putting S3 object: %w", err)
@@ -96,7 +104,7 @@ type Upload struct {
96104
Key string
97105
ContentType string
98106
Body []byte
99-
ACL string
107+
ACL types.ObjectCannedACL
100108

101109
// set by BatchPut
102110
URL string
@@ -154,12 +162,12 @@ func (s *Service) batchWorker(ctx context.Context, uploads chan *Upload, errors
154162
uctx, cancel := context.WithTimeout(ctx, time.Second*15)
155163
defer cancel()
156164

157-
_, err = s.Client.PutObjectWithContext(uctx, &s3.PutObjectInput{
165+
_, err = s.Client.PutObject(uctx, &s3.PutObjectInput{
158166
Bucket: aws.String(u.Bucket),
159167
Body: bytes.NewReader(u.Body),
160168
Key: aws.String(u.Key),
161169
ContentType: aws.String(u.ContentType),
162-
ACL: aws.String(u.ACL),
170+
ACL: u.ACL,
163171
})
164172

165173
if err == nil {
@@ -186,27 +194,27 @@ func (s *Service) EmptyBucket(ctx context.Context, bucket string) error {
186194
request := &s3.ListObjectsV2Input{Bucket: aws.String(bucket)}
187195

188196
for {
189-
response, err := s.Client.ListObjectsV2WithContext(ctx, request)
197+
response, err := s.Client.ListObjectsV2(ctx, request)
190198
if err != nil {
191199
return fmt.Errorf("error listing S3 objects: %w", err)
192200
}
193201

194202
if len(response.Contents) > 0 {
195-
del := &s3.Delete{}
203+
del := &types.Delete{}
196204

197205
for _, obj := range response.Contents {
198-
del.Objects = append(del.Objects, &s3.ObjectIdentifier{Key: obj.Key})
206+
del.Objects = append(del.Objects, types.ObjectIdentifier{Key: obj.Key})
199207
}
200208

201-
_, err = s.Client.DeleteObjectsWithContext(ctx, &s3.DeleteObjectsInput{Bucket: aws.String(bucket), Delete: del})
209+
_, err = s.Client.DeleteObjects(ctx, &s3.DeleteObjectsInput{Bucket: aws.String(bucket), Delete: del})
202210
if err != nil {
203211
return fmt.Errorf("error deleting S3 objects: %w", err)
204212
}
205213
}
206214

207215
request.ContinuationToken = response.NextContinuationToken
208216

209-
if !aws.BoolValue(response.IsTruncated) {
217+
if !aws.ToBool(response.IsTruncated) {
210218
break
211219
}
212220
}

s3x/service_test.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ import (
44
"context"
55
"testing"
66

7-
"github.com/aws/aws-sdk-go/aws"
8-
"github.com/aws/aws-sdk-go/service/s3"
7+
"github.com/aws/aws-sdk-go-v2/aws"
8+
"github.com/aws/aws-sdk-go-v2/service/s3"
9+
"github.com/aws/aws-sdk-go-v2/service/s3/types"
910
"github.com/nyaruka/gocommon/s3x"
1011
"github.com/stretchr/testify/assert"
1112
)
@@ -17,15 +18,15 @@ func TestService(t *testing.T) {
1718
assert.NoError(t, err)
1819

1920
err = svc.Test(ctx, "gocommon-tests")
20-
assert.ErrorContains(t, err, "NotFound: Not Found\n\tstatus code: 404")
21+
assert.ErrorContains(t, err, "NotFound")
2122

22-
_, err = svc.Client.CreateBucket(&s3.CreateBucketInput{Bucket: aws.String("gocommon-tests")})
23+
_, err = svc.Client.CreateBucket(ctx, &s3.CreateBucketInput{Bucket: aws.String("gocommon-tests")})
2324
assert.NoError(t, err)
2425

2526
err = svc.Test(ctx, "gocommon-tests")
2627
assert.NoError(t, err)
2728

28-
url, err := svc.PutObject(ctx, "gocommon-tests", "1/hello world.txt", "text/plain", []byte("hello world"), s3.BucketCannedACLPublicRead)
29+
url, err := svc.PutObject(ctx, "gocommon-tests", "1/hello world.txt", "text/plain", []byte("hello world"), types.ObjectCannedACLPublicRead)
2930
assert.NoError(t, err)
3031
assert.Equal(t, "http://localhost:9000/gocommon-tests/1/hello+world.txt", url)
3132

@@ -41,14 +42,14 @@ func TestService(t *testing.T) {
4142
Key: "foo/thing1",
4243
Body: []byte(`HELLOWORLD`),
4344
ContentType: "text/plain",
44-
ACL: s3.BucketCannedACLPublicRead,
45+
ACL: types.ObjectCannedACLPublicRead,
4546
},
4647
{
4748
Bucket: "gocommon-tests",
4849
Key: "foo/thing2",
4950
Body: []byte(`HELLOWORLD2`),
5051
ContentType: "text/plain",
51-
ACL: s3.BucketCannedACLPublicRead,
52+
ACL: types.ObjectCannedACLPublicRead,
5253
},
5354
}
5455

@@ -68,7 +69,7 @@ func TestService(t *testing.T) {
6869
assert.NoError(t, err)
6970

7071
// test deleting a bucket
71-
_, err = svc.Client.DeleteBucket(&s3.DeleteBucketInput{Bucket: aws.String("gocommon-tests")})
72+
_, err = svc.Client.DeleteBucket(ctx, &s3.DeleteBucketInput{Bucket: aws.String("gocommon-tests")})
7273
assert.NoError(t, err)
7374

7475
err = svc.Test(ctx, "gocommon-tests")

0 commit comments

Comments
 (0)