Skip to content

Updating bootstrap and font awesome #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougcsicam opened this issue Mar 22, 2019 · 7 comments
Closed

Updating bootstrap and font awesome #143

dougcsicam opened this issue Mar 22, 2019 · 7 comments
Assignees
Labels
question Further information is requested

Comments

@dougcsicam
Copy link

Please summarize your question in one sentence

Whay would be the correct procedure to upgrade Bootstrap and Font Awesome to the latest version within this framework.

Give a more extended description

Steps to reproduce (if needed)

Other comments or remarks

@david-poindexter david-poindexter self-assigned this Mar 22, 2019
@david-poindexter david-poindexter added the question Further information is requested label Mar 22, 2019
@david-poindexter
Copy link
Member

@dougcsicam which version of nvQuickTheme are you using? If you are version 2.0.0 then all you need to do is run the appropriate yarn upgrade bootstrap or yarn upgrade font-awesome command(s). You can also modify the versions in package.json and re-run yarn or yarn install, though that is not the recommended best practice.

@dougcsicam
Copy link
Author

I was able to upgrade bootstrap but not fontawesome. I used
yarn upgrade [email protected]
This is what it returns
Couldn't find any versions for "font-awesome" that matches "5.8.1"
? Please choose a version of "font-awesome" from this list:

4.7.0
4.6.3
4.6.1
4.5.0

@david-poindexter
Copy link
Member

The package names for Font Awesome 5 changed. Try @fortawesome/fontawesome-free

@david-poindexter
Copy link
Member

You need to uninstally Font Aesome 4 and install Font Awesome 5.

@dougcsicam
Copy link
Author

dougcsicam commented May 11, 2019

I upgated to fontawesome 5 after uninstalling 4 with the command:
yarn add --dev @fortawesome/fontawesome-free
When I do the build I get the error:
'faCssInit' errored after 9.21 ms
[10:34:00] Error: File not found with singular glob: C:/inetpub/wwwroot/dnndev/Portals/_default/Skins/SicamQtTheme/node_modules/font-awesome/css/font-awesome.min.css (if this was purposeful, use allowEmpty option)

@david-poindexter
Copy link
Member

@dougcsicam when using Font Awesome 5, that will create a new folder within node_modules for @fortawesome/fontawesome-free. Therefore, gulpfile.js will need to be updated to accommodate the new Font Awesome location. THIS LINE change would need to be updated to match the location of the minified CSS file.

@david-poindexter
Copy link
Member

Issues #156 and #157 have been added to address this in nvQuickTheme and has been added to Milestone 2.1.0. Closing this issue as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants