Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Upstream) Concealed formula width incorrectly identified as non-concealed when linewrapping #1444

Closed
2 tasks done
glyh opened this issue May 28, 2024 · 8 comments
Closed
2 tasks done
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.

Comments

@glyh
Copy link

glyh commented May 28, 2024

Prerequisites

  • I am using the latest stable release of Neovim
  • I am using the latest version of the plugin

Neovim Version

NVIM v0.10.0 Build type: Release LuaJIT 2.1.1716656478

Neorg setup

config = function()
  require("neorg").setup {
    load = {
      ["core.defaults"] = {},
      ["core.export"] = {},
      ["core.export.markdown"] = {},
      ["core.concealer"] = {},
      ["core.completion"] = {
        config = {
          engine = "nvim-cmp",
        },
      },
      ["core.dirman"] = {
        config = {
          workspaces = {
            notes = "~/Documents/notes/neorg",
          },
          default_workspace = "notes",
        },
      },
      ["core.integrations.image"] = {},
      ["core.latex.renderer"] = {},
    },
  }
  -- TODO: Set fold level only for neorg files
  vim.wo.foldlevel = 99
  vim.wo.conceallevel = 2

Actual behavior

image

The green line is the right border of the window.

Expected behavior

The hi should fit in one line.

Steps to reproduce

Write the below

* Benefits of z-Transform
  - Analysis of LTI systems
  - Solving difference equations
  - Determining system stability
  - Finding frequency response of stable systems
* Eigen-functions of LTI Systems
  $|e^{j\omega n}|$ are eigen-functions, so are $|x[n] = z^n = r^n e^{j\omega n}|$ hi.

Potentially conflicting plugins

None

Other information

Is this a neovim bug?

Help

Yes, but I don't know how to start. I would need guidance (check question below)

Implementation help

Tell me where should I start.

@glyh glyh added the bug Issues related to bugs. Please attach a severity, a priority and category with this label. label May 28, 2024
@github-project-automation github-project-automation bot moved this to added-updated-reopened in sorting neorg issue tracker May 28, 2024
@max397574
Copy link
Contributor

max397574 commented May 28, 2024

nothing we can do about that afaik
it's the same with e.g. links

@glyh
Copy link
Author

glyh commented May 28, 2024

So this is an upstream bug? How should I formulate it to upstream then?

@max397574
Copy link
Contributor

you shouldn't because there are open issues for the concealing limitations

@glyh
Copy link
Author

glyh commented May 28, 2024

You mean this? neovim/neovim#18282

@max397574
Copy link
Contributor

max397574 commented May 28, 2024

especially this neovim/neovim#25718 ig

you can try opening an issue with saying "inline formulas in neorg aren't concealed correctly" but the chance of it being closed is about 99%
either you wait until these bigger concealing things get done or you try to produce a minimal config to open an issue upstream

@glyh
Copy link
Author

glyh commented May 28, 2024

Ok, I guess I'll just leave this here as upstream tracker.

@max397574
Copy link
Contributor

not needed
duplicate of/related to:
#1065
#929
https://github.com/nvim-neorg/neorg/wiki/Dependencies#ugly-line-wraps-when-concealing-text
#292 (comment)
#292 (comment)

I'm quite sure there are even more who were already closed and perhaps even some more open ones but ig you got my point already

@glyh glyh changed the title Concealed formula width incorrectly identified as non-concealed when linewrapping (Upstream) Concealed formula width incorrectly identified as non-concealed when linewrapping May 28, 2024
@glyh
Copy link
Author

glyh commented May 29, 2024

Great, let me close this then.

@glyh glyh closed this as completed May 29, 2024
@github-project-automation github-project-automation bot moved this from added-updated-reopened to done in sorting neorg issue tracker May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.
Projects
None yet
Development

No branches or pull requests

2 participants