Skip to content

Commit 5490c43

Browse files
authored
fix: do not expose token in public runtime config (#41)
* fix: do not expose token in public runtime config * fix: remove formatting change * refactor: avoid setting token in first place
1 parent 140314f commit 5490c43

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/module.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ export default defineNuxtModule<ModuleOptions>({
6969
owner: options.owner || process.env.GITHUB_OWNER,
7070
branch: options.branch || process.env.GITHUB_BRANCH,
7171
repo: options.repo || process.env.GITHUB_REPO,
72-
token: options.token || process.env.GITHUB_TOKEN,
7372
disableCache: options.disableCache,
7473
parseContents: options.parseContents,
7574
maxContributors: options.maxContributors
@@ -79,7 +78,9 @@ export default defineNuxtModule<ModuleOptions>({
7978
// @ts-ignore
8079
nuxt.options.runtimeConfig.public.github = defu(nuxt.options.runtimeConfig.public.github, config)
8180
// @ts-ignore
82-
nuxt.options.runtimeConfig.github = defu(nuxt.options.runtimeConfig.github, config)
81+
nuxt.options.runtimeConfig.github = defu(nuxt.options.runtimeConfig.github, {
82+
token: options.token || process.env.GITHUB_TOKEN
83+
}, config)
8384

8485
// Autolink issue/PR/commit links using `remark-github` plugin
8586
if (options.remarkPlugin) {

0 commit comments

Comments
 (0)