fix!: ScriptCarbonAds prefer ready event

harlan-zw · harlan-zw · commit d32e0d88f88d · 2024-07-06T18:05:34.000+10:00
diff --git a/src/runtime/components/ScriptCarbonAds.vue b/src/runtime/components/ScriptCarbonAds.vue
@@ -14,7 +14,7 @@ const props = defineProps<{
 
 const emit = defineEmits<{
   error: [error: string | Event]
-  load: []
+  ready: [HTMLScriptElement]
 }>()
 
 const attrId = `_carbonads_js`
@@ -40,7 +40,7 @@ function loadCarbon() {
   }
   script.onload = () => {
     status.value = 'loaded'
-    emit('load')
+    emit('ready', script)
   }
   carbonadsEl.value.appendChild(script)
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ const props = defineProps<{`
`14`	`14`
`15`	`15`	`const emit = defineEmits<{`
`16`	`16`	`error: [error: string \| Event]`
`17`		`- load: []`
	`17`	`+ ready: [HTMLScriptElement]`
`18`	`18`	`}>()`
`19`	`19`
`20`	`20`	const attrId = `_carbonads_js`
`@@ -40,7 +40,7 @@ function loadCarbon() {`
`40`	`40`	`}`
`41`	`41`	`script.onload = () => {`
`42`	`42`	`status.value = 'loaded'`
`43`		`- emit('load')`
	`43`	`+ emit('ready', script)`
`44`	`44`	`}`
`45`	`45`	`carbonadsEl.value.appendChild(script)`
`46`	`46`	`}`