Skip to content

Commit 92e94e3

Browse files
authored
chore: use packlist to write node_module ignores (#5363)
The gitignore file inside `node_modules/` is now an allow list built from the output of `npm-packlist`. This means that the only dependencies that get checked in to source control are those that will end up in the packed tarball, with the exception of some files that we always ignore. This also moves the dependencies required to build the docs workspace from devDependencies to dependencies so they are available for making the docs after pruning. Ignoring these from source control was the reason that the change to how we build the gitignore file was necessary.
1 parent e9eda68 commit 92e94e3

File tree

39 files changed

+823
-14596
lines changed

39 files changed

+823
-14596
lines changed

DEPENDENCIES.md

Lines changed: 323 additions & 1 deletion
Large diffs are not rendered by default.

docs/.eslintrc.local.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

docs/package.json

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,21 @@
1717
"url": "https://github.com/npm/cli.git",
1818
"directory": "docs"
1919
},
20-
"devDependencies": {
20+
"dependencies": {
2121
"@mdx-js/mdx": "^1.6.22",
22+
"cmark-gfm": "^0.9.0",
23+
"jsdom": "^18.1.0",
24+
"marked-man": "^0.7.0",
25+
"mkdirp": "^1.0.4",
26+
"yaml": "^1.10.2"
27+
},
28+
"devDependencies": {
2229
"@npmcli/eslint-config": "^3.1.0",
2330
"@npmcli/fs": "^2.1.0",
2431
"@npmcli/promise-spawn": "^3.0.0",
2532
"@npmcli/template-oss": "4.5.0",
26-
"cmark-gfm": "^0.9.0",
27-
"jsdom": "^18.1.0",
28-
"marked-man": "^0.7.0",
2933
"tap": "^16.0.1",
30-
"which": "^2.0.2",
31-
"yaml": "^1.10.0"
34+
"which": "^2.0.2"
3235
},
3336
"author": "GitHub Inc.",
3437
"license": "ISC",

0 commit comments

Comments
 (0)