Merge pull request #56 from jdecool/manager-initialization-detect

Manager initialization detection

Author: skwi

Manager/Traits/FileManagerTrait.php

@@ -27,14 +27,19 @@ trait FileManagerTrait
      */
     protected $webPath;
 
+    /**
+     * @var bool
+     */
+    private $booted = false;
+
 
     /**
      * Initialize trait properties
      *
      * @param array $arrayFilepath Associative array containing the file path for each property of the managed entity.
      *                             This array must also contain a 'root' and a 'web' path.
      */
-    protected function initialize($arrayFilepath)
+    protected function initialize(array $arrayFilepath)
     {
         if (!isset($arrayFilepath['bundle.web'])) {
             throw new \InvalidArgumentException('$arrayFilepath must have a bundle.web key (even empty).');
@@ -52,6 +57,8 @@ protected function initialize($arrayFilepath)
             $this->rootPath  = $classDir.'/../../../../../../../web'.$this->webPath;
         }
         $this->arrayFilepath = $arrayFilepath;
+
+        $this->booted = true;
     }
 
     /**
@@ -65,6 +72,10 @@ protected function initialize($arrayFilepath)
      */
     public function saveWithFiles(BaseEntityWithFile $entity, $callback = null)
     {
+        if (!$this->booted) {
+            throw new \Exception('Manager has not been initialized');
+        }
+
         $managedProperties = $this->arrayFilepath;
         $managedProperties = array_keys($managedProperties);
 
@@ -104,6 +115,10 @@ public function saveWithFiles(BaseEntityWithFile $entity, $callback = null)
      */
     public function deleteWithFiles(BaseEntityWithFile $entity)
     {
+        if (!$this->booted) {
+            throw new \Exception('Manager has not been initialized');
+        }
+
         $managedProperties = $this->arrayFilepath;
         $managedProperties = array_keys($managedProperties);
 

Manager/Traits/ImageManagerTrait.php

@@ -37,7 +37,7 @@ trait ImageManagerTrait
      * @param array $imageFormatDefinition Associative array to define image properties which be stored on filesystem
      * @param array $imageFormatChoices    Associative array to apply some format definitions to an entity property
      */
-    protected function initialize($arrayFilepath, $imageFormatDefinition, $imageFormatChoices)
+    protected function initialize(array $arrayFilepath, $imageFormatDefinition, $imageFormatChoices)
     {
         $this->parentInitialize($arrayFilepath);